From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 617953BA8E for ; Wed, 20 Dec 2017 19:54:38 -0500 (EST) Received: by mail-wm0-x22e.google.com with SMTP id r78so13128156wme.5 for ; Wed, 20 Dec 2017 16:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=B/jeh1PudaAF6faduqUDahhs0HwtGhY1nwpmw5KxZ9w=; b=KyEV2KYMpASW3d8FQMFpiwxiUNrATTKXRBQZovRmBRg7FdwqUNVT46poVZ04xrJbes e315hhM1PAE81VwPQb/pV/3bgYa3VaH7fOLIoq9HI/JTlbqEAewTo0rgC5BZTqP6ucHz 2u3+HJ3zT9/X9wsz68ewDE7S/P8dCrEmEjbXH33WqB+flJl3/rf/s5ldeclrH26dxggj uJIWOODXTp8eRkxwe6OWo9QjENC6Z2zrf3JnvLhozvo8uoJ/II00neaOV0i717qR8nKu qXL+EthxahJp19aGHiUMxmocyUaeHuE+rwXniqukCan2WGH8ZJFUWB7qTJu3M6MsuWcf yB5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=B/jeh1PudaAF6faduqUDahhs0HwtGhY1nwpmw5KxZ9w=; b=ruOKhCt+znbOj7XJoHsCXpuHP9mSZNbKKOE+XS6man3eW0Ud3gQPPyuowHfrnXsdVZ 5VP4WBtEJt7Nz6BeZJUI8BMVSwhQXWp3mGvwKxH462wYIeT28p6T3g/rOiGUnFJEoUOj nRfLMRYcw7F7OPacScuV1x9le/jUpA+5CQe+NsYZrF14SQuxRtTIgwCYNqOjXKE5X6FC pnQ9CHs1mphQC9+jioxqM2iIzcXzBx+xSA0PF3W/1OZBIs5dfWViBxgYJ40OGCbDCw5a KZkHBXzGSOg/6DVBJeiRATqeX6YtcBTxgS6CRJBOwe7KP/A2+UVbKSWo0HmQuRv1rxmk cRJA== X-Gm-Message-State: AKGB3mLDcawYeJJVTtErYN0r9hv1PICfJ0ZTj4fTA4Eukt6L+5Kd72O0 /1qFCXeZo5hTOLZ0gsl9Ag+Asg== X-Google-Smtp-Source: ACJfBovRAk92fddYaOUvaoWR4UVksTybkxoZyOUjP2KLsjAYQ0Tb/0PHdn7I0aLHo8eI5OYoRx657Q== X-Received: by 10.28.48.1 with SMTP id w1mr8270447wmw.119.1513817677336; Wed, 20 Dec 2017 16:54:37 -0800 (PST) Received: from [192.168.0.3] (209.77.159.143.dyn.plus.net. [143.159.77.209]) by smtp.gmail.com with ESMTPSA id w14sm188220wra.87.2017.12.20.16.54.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Dec 2017 16:54:36 -0800 (PST) From: Andy Furniss To: Cake@lists.bufferbloat.net References: <31d49a5d-02a2-3dc8-a455-52d453b83bdf@gmail.com> Message-ID: Date: Thu, 21 Dec 2017 00:54:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0 SeaMonkey/2.51a2 MIME-Version: 1.0 In-Reply-To: <31d49a5d-02a2-3dc8-a455-52d453b83bdf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Cake] overheads or rate calculation changed? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 00:54:38 -0000 Andy Furniss wrote: > Been running a cake cobolt from april for some time using > > tc qdisc add dev ppp0 handle 1:0 root cake bandwidth 19690kbit raw > overhead 34 diffserv4 dual-srchost nat rtt 200ms > > tc -s qdisc ls dev ppp0 (ppp0 is pppoe) > > qdisc cake 1: root refcnt 2 bandwidth 19690Kbit diffserv4 dual-srchost > nat rtt 200.0ms noatm overhead 56 via-ethernet > > Which is backed off a couple of kbit and tests well (overhead 33 + udp > flood is over limit) > > With current cobalt + current tc the same command is under rate - I > don't know if its rate calculation or overheads calc changed. > > overhead 20 (-14) is still under but overhead 12 (-22) is over. > > I was hoping one of those would be correct, but no. > > Any ideas/known changes? Bisected to - f33c4d6a08cb21374ce52fc1438a8531bc84bcbe is the first bad commit commit f33c4d6a08cb21374ce52fc1438a8531bc84bcbe Author: Dave Taht Date: Wed Nov 22 16:21:13 2017 -0800 refactor cake_advance_shaper and ack_filter cake_advance_shaper now returns a modified len argument to reflect cake_overhead. skb_ack_filter variable replaced with ack