From: Matt Johnston <matt@codeconstruct.com.au>
To: "Sebastian Moeller" <moeller0@gmx.de>,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>,
cake@lists.bufferbloat.net, Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [Cake] [PATCH net] sch_cake: diffserv8 CS1 should be bulk
Date: Thu, 27 Jan 2022 11:14:13 +0800 [thread overview]
Message-ID: <db81c2b5bd1fb2fb6410ce0d04e577bbff61ee1e.camel@codeconstruct.com.au> (raw)
In-Reply-To: <242985FC-238B-442D-8D86-A49449FF963E@gmx.de>
On Tue, 2022-01-25 at 12:54 +0100, Sebastian Moeller wrote:
>
> LE(1) is tin 0 the lowest
> CS1(8) is 1 slightly above LE
> CS0/BE(0) is 2
> AF1x (10, 12, 14) are all in tin 1 as is CS1
...
> Just as documented in the code:
>
> * Bog Standard (CS0 etc.)
> * High Throughput (AF1x, TOS2)
> * Background Traffic (CS1, LE)
The documentation doesn't match the code though. Almost, but it's off by one.
I can submit a patch instead to change the docs, though it's not clear the
divergence between code and docs was intended in the first place.
(diffserv8 also needs a description in the cake manpage, I'll send a patch
for that once the order is clarified)
Cheers,
Matt
next prev parent reply other threads:[~2022-01-27 3:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 6:04 Matt Johnston
2022-01-25 10:58 ` Toke Høiland-Jørgensen
2022-01-25 11:54 ` Sebastian Moeller
2022-01-27 3:14 ` Matt Johnston [this message]
2022-01-27 16:00 ` Sebastian Moeller
2022-01-28 4:31 ` Matt Johnston
2022-01-27 9:00 ` Kevin 'ldir' Darbyshire-Bryant
2022-01-27 16:02 ` Sebastian Moeller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db81c2b5bd1fb2fb6410ce0d04e577bbff61ee1e.camel@codeconstruct.com.au \
--to=matt@codeconstruct.com.au \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=ldir@darbyshire-bryant.me.uk \
--cc=moeller0@gmx.de \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox