From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x233.google.com (mail-pg0-x233.google.com [IPv6:2607:f8b0:400e:c05::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 55E5C3BA8E for ; Wed, 25 Apr 2018 11:48:32 -0400 (EDT) Received: by mail-pg0-x233.google.com with SMTP id b9so13624175pgf.6 for ; Wed, 25 Apr 2018 08:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QpdQ1w1/Kaej2TTCUiSZe4rEU1QiIt0b268ek4zhTwg=; b=vfp0eKm8Owg8Lrp0UgNX72VflXk4zh9YEFS4cAib4iKaB/sJ19NLZj1DLU8TdrVOC1 Vpqoik3MprAC2xmIsc87j7pgP2V7NEE6WJes8CSy8HJj6FonzMUcEHf8FFzObNQEpQoj uOxRax4CJunVVOBCKTKS9EcrlPhkBhguk3mkePZYZ244qr+3G4iAZcnspYY0/DNzDGlE 3UwfpKyw8sdA5CXB8u53vvzdDfO8MGOJSnrvFgv86QBbT4gY2SHgfnVIi1zYYYXh1xBD WdCC8T0e5lhE4+AlBgIXcsJ9lOJlgiu5nJNqYZSzvbEvZo9lyyRVa5RaZRNInChGuTcD aezw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QpdQ1w1/Kaej2TTCUiSZe4rEU1QiIt0b268ek4zhTwg=; b=i12qhMWSsakELImWmVis2CuAUuTpGF8q34HOyJp4QyJ0psJ9h37+toAL3iLXMa0MdE xcL68Hc/SnOKryzWDaoj4xwPc8CdzWJ/hNjMVtU2/sTm3sPiEmNiCaylWmtWkjfxB63Y na33FC9jkUfhUQtyD0bmINApul2b+CJ6R1OCRg3tH0SodJD1hWK2Y9OyMFpeGUfUpQ+k yKOU9VI0AhpwMDiKOI4DUvJlmKjz7r6Or4hVi/CGOXyDQC2xfBg1q1+ePoHr3hA8X9vd Mp28zjDXP6spiCbNhTNlV2fzSLR1uTni3vY8bdBukjuUqa5wos+EjluctFPVBaE/4VrQ DvIg== X-Gm-Message-State: ALQs6tA+1puDs9O1Cc/+8Z1PgZvRSH4AfBOkpeTyyEWrVmlmZzJ4jvtS cWjf5J9A/HJ3Iy7BSExzp4A= X-Google-Smtp-Source: AIpwx48+IvhGnWPmShGwrAI4jF+kfExeicVaWkzIuMdmtf5JNRyhQoLRfYlRh6EWhZFBqLR7aMm/VA== X-Received: by 2002:a17:902:7042:: with SMTP id h2-v6mr30053305plt.249.1524671311672; Wed, 25 Apr 2018 08:48:31 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id 27sm35504094pfo.137.2018.04.25.08.48.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Apr 2018 08:48:30 -0700 (PDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Eric Dumazet , netdev@vger.kernel.org Cc: cake@lists.bufferbloat.net, Dave Taht References: <20180425134249.21300-1-toke@toke.dk> <878t9b5n0q.fsf@toke.dk> From: Eric Dumazet Message-ID: Date: Wed, 25 Apr 2018 08:48:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <878t9b5n0q.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 15:48:32 -0000 On 04/25/2018 08:22 AM, Toke Høiland-Jørgensen wrote: > Hmm, because pure ACKs are not generally aggregated (sorry, I'm not > quite clear on when exactly GSO will kick in)? A GSO packet must contain payload in each of its segment. There is no way some ack aggregation logic could build a GSO packet out of pure acks.