From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter
Date: Mon, 21 May 2018 10:18:32 -0700 [thread overview]
Message-ID: <f7a7917b-9d81-b192-514b-3861321a4892@gmail.com> (raw)
In-Reply-To: <152691985736.4083.3416150561524698541.stgit@alrua-kau>
On 05/21/2018 09:24 AM, Toke Høiland-Jørgensen wrote:
> + while (oplen_tmp >= 8) {
> + u32 right_b = get_unaligned_be32(sack_tmp + 4);
> + u32 left_b = get_unaligned_be32(sack_tmp);
> +
> + if (left_b >= right_b)
> + continue;
> +
> + if (first)
> + bytes_b += right_b - left_b;
> +
> + if (left_b <= left_a && right_a <= right_b) {
> + found = true;
> + if (!first)
> + break;
> + }
> + oplen_tmp -= 8;
> + sack_tmp += 8;
> + }
>
This is obviously incorrect.
Please take a look at TCP stack, and how it handles sequence wrapping with following macros :
after(), before()
Quite frankly O wonder how this was really tested.
next prev parent reply other threads:[~2018-05-21 17:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 16:24 [Cake] [PATCH net-next v13 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter Toke Høiland-Jørgensen
2018-05-21 17:18 ` Eric Dumazet [this message]
2018-05-21 17:35 ` Toke Høiland-Jørgensen
2018-05-21 18:08 ` Eric Dumazet
2018-05-21 18:17 ` Eric Dumazet
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 5/7] sch_cake: Add DiffServ handling Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 2/7] sch_cake: Add ingress mode Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 6/7] sch_cake: Add overhead compensation support to the rate shaper Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 7/7] sch_cake: Conditionally split GSO segments Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-21 16:24 ` [Cake] [PATCH net-next v13 4/7] sch_cake: Add NAT awareness to packet classifier Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7a7917b-9d81-b192-514b-3861321a4892@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox