From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 778B93BA8E for ; Mon, 21 May 2018 13:18:34 -0400 (EDT) Received: by mail-pg0-x241.google.com with SMTP id c22-v6so5968017pgn.11 for ; Mon, 21 May 2018 10:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=8euhb5o/tNb0WaBt1i1CIkeFOGp1vaDdGKqsxMO5QGA=; b=HYHa/tRWJTP4yFP1/n8wy+yq7nfkpBN4qJ82uRktvxBn8gJjNc0ES8qpH0C7aItPoV d5eevigHux5x9zTTP+Y4dDoBlmcp/ru1uYNhAnMMQDEtKia11nWXbFwtvGuw5yTsBShg 6QwcExwAkVCJwaAcCyrzUc7U8vKS/gyzGvI7T918os+Gj0EVwGat4QfS/YD+VfGz4yt7 ttvmcQss4Pt+Jja/3/eMSjWsi4Vs0ShGaJun1eJ76wyxG5lh6y3cupnqcBQoz/TfIgdT nFl16gebVr0ehklOZy+ChnhQl+9lqp9ODiTMKEjRPA27S2zyVKrQYN2JXrK1822+7UM9 uvhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8euhb5o/tNb0WaBt1i1CIkeFOGp1vaDdGKqsxMO5QGA=; b=Ige1e8DPSkkH49AiZNx5msdPWg2l4/J52vJ8Sr3HLvWcigA81RG//J3gi2tIzRTOK0 7Bbe+pw26JgO3ehoC4NbYOqQI6t5cbyw55AcU8VtrWZZVpVAQkfNd7klRNSB+7tzE/xt D30GvJMf+nndz5z0XNmTZl/6Rjy2l2RpRLiGQZ7zxan1PaWLldrcc/wjKnneQVMZXK3B GcyhjBOLJzbZ8Vo2p7lvWBWgFlFUsyClyImfsvYmAi9gu04NspqGdrwahvfaM/QFcrM5 0Cc3vNFkUyt9UaKdqXLbdabSkcYCGeWoH4bEHUzPuBxK5CSayJ4vRk3OVEGaMiYK4BO5 uNdg== X-Gm-Message-State: ALKqPweb3Gl7fHW6RcO20a6Mc4g4GtUgyhR4MADyFWuC5m30hVeUdBwP ST+SV93Feyx9yBs6TY2LD4tbFU8P X-Google-Smtp-Source: AB8JxZpTiuNP33dTvm47JSoTuh48YHQRDP7LruhWumvK00y74W/faqC30cP4rE6J7F6iwUcxupH28A== X-Received: by 2002:a63:bd49:: with SMTP id d9-v6mr16732060pgp.14.1526923113573; Mon, 21 May 2018 10:18:33 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id c3-v6sm26683801pfn.62.2018.05.21.10.18.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 May 2018 10:18:32 -0700 (PDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , netdev@vger.kernel.org, cake@lists.bufferbloat.net References: <152691970035.4083.3349902669266371765.stgit@alrua-kau> <152691985736.4083.3416150561524698541.stgit@alrua-kau> From: Eric Dumazet Message-ID: Date: Mon, 21 May 2018 10:18:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <152691985736.4083.3416150561524698541.stgit@alrua-kau> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 17:18:34 -0000 On 05/21/2018 09:24 AM, Toke Høiland-Jørgensen wrote: > + while (oplen_tmp >= 8) { > + u32 right_b = get_unaligned_be32(sack_tmp + 4); > + u32 left_b = get_unaligned_be32(sack_tmp); > + > + if (left_b >= right_b) > + continue; > + > + if (first) > + bytes_b += right_b - left_b; > + > + if (left_b <= left_a && right_a <= right_b) { > + found = true; > + if (!first) > + break; > + } > + oplen_tmp -= 8; > + sack_tmp += 8; > + } > This is obviously incorrect. Please take a look at TCP stack, and how it handles sequence wrapping with following macros : after(), before() Quite frankly O wonder how this was really tested.