From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 1CB6F3CB38 for ; Thu, 5 Aug 2021 04:55:43 -0400 (EDT) Received: by mail-ej1-x634.google.com with SMTP id hs10so8418441ejc.0 for ; Thu, 05 Aug 2021 01:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=KaN4CwF6oSZdTgBH7HAi15oXYpnGQKpmASv6gYuTtmk=; b=V1sx+t0j03tQDepSHU9rmwqG7fBmNq10+MyrSKslSdkZJUHqYM8I10saTvTnuwhH72 cLSTEv82khvxkhQfNpcxyfPjNoSiHLwAx3NxtqoXyWR2lFzmajT4q2jhmbHkiKoKLy7n yiLz2K0JzR4c17ImvL1jP1UpR8hj2k06O3Vj21D56+EOy2r6QLPdcEWVNRiRv54A2Jkr 0R8KeNod+pDiDhhPyiWl2kDazYkm+aRhOY09A5i6rSbdPBmih3kE/vhmRhhQ7rH9+gMz pGM7qVpDNREFpULPjoyAP/REBV2t33aMlBTtZ2w1+dzYF0Gw1X/zRGyE9z4iTDuiEwAE 3VVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=KaN4CwF6oSZdTgBH7HAi15oXYpnGQKpmASv6gYuTtmk=; b=Ptt2J3mwuzxCB8LWi4V7eRpivct8U+UIbU4DLUUvRROiazFCKjbdqD89h37Pm6LjVh dbE+23Nmr1P20/20hkBi1UgauQhUzjpAiRo9INYfVZoQH+TFakbqJq6fpo/mN5DJX0n9 Nq6ex9sQ6BhhiI72+2Uc8QpFjLD2gJJDZufd0ihcztnpLuiUQZmTQa3saOubBEyNQMoV 6OrbaVL4bJJmzHDKb+lAU5+8YgW7JiMx3VL8qlFHogIJCGESYFC5nD0Dg071VxVtVvVV tuyARg7fypAtU3x4WoIgPB83hzlFOpcc+06T8nvrFKEzYOk9I5wiyAJgv4tm1GoS2ydJ +hBQ== X-Gm-Message-State: AOAM531RIIUbRomSd1cvDAbn2HSlGJbGElRI8Ua/tIvrszEqgHNGFFRa g458QHP+BeS9KyAyRPMwX9LlJA== X-Google-Smtp-Source: ABdhPJyYAJqoPYHJ69jiMXjaAevKp8tN6xRJfqf9q1uHJloUI2vZuOCySuUYbkbkNW8Kkcc4Z1BG2Q== X-Received: by 2002:a17:906:350c:: with SMTP id r12mr3770337eja.44.1628153741989; Thu, 05 Aug 2021 01:55:41 -0700 (PDT) Received: from sova.luk.heistp.net (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id mf11sm1503188ejb.27.2021.08.05.01.55.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 01:55:41 -0700 (PDT) Message-ID: From: Pete Heist To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: Cake List Date: Thu, 05 Aug 2021 10:55:39 +0200 In-Reply-To: <37822e2cebd977f2c5c0758b48a191f2644d7589.camel@heistp.net> References: <3ebc0a3ccdcfa67a48c5ad764ce3389782633fef.camel@heistp.net> <87r1f95und.fsf@toke.dk> <5964374bee9979ee9f1b4b86d32b002722d628fc.camel@heistp.net> <37822e2cebd977f2c5c0758b48a191f2644d7589.camel@heistp.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Cake] cake srchost/dsthost stopped working? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 08:55:43 -0000 As for triple-isolate, I added a test Jon suggested: "I would recommend a W configuration of flows one of the three hosts sends to or from both of the two hosts, while the other two send to or from only one each this should result in the two hosts getting equal throughput each, and equal throughput in each of their two flows" This is the last test in the output, and I think the behavior looks correct for both the unpatched and patched versions: https://www.heistp.net/downloads/cake-hostfair/cake-hostfair-unpatched.txt https://www.heistp.net/downloads/cake-hostfair/cake-hostfair-patched.txt Thanks guys, and that, I believe, is finally it for now... :) Pete On Thu, 2021-08-05 at 00:52 +0200, Pete Heist wrote: > I ended up testing each of the keywords, with two src IPs then two dst > IPs, and I think everything makes sense: > > https://www.heistp.net/downloads/cake-hostfair/cake-hostfair-patched.txt > > I'm only not sure if we can tell from this test if triple-isolate is > doing what it should... > > Pete > > On Wed, 2021-08-04 at 22:49 +0200, Pete Heist wrote: > > Great, that seems to fix it. :) For sanity, I confirmed that I can > > apply/unapply the patch to fix/break it, so all seems well. > > > > Is there anything that you'd want to make sure still works after the > > patch? I don't have any official regression tests to run, but with > > this > > setup ready I should be able to test something easily if needed... > > > > Pete > > > > On Wed, 2021-08-04 at 13:14 +0200, Toke Høiland-Jørgensen wrote: > > > Pete Heist writes: > > > > > > > One more tip, reverting this commit seems to fix it: > > > > > > > > https://github.com/torvalds/linux/commit/b0c19ed6088ab41dd2a727b60594b7297c15d6ce > > > > > > Ah, I think I see what the problem is; could you please try the > > > patch > > > below? > > > > > > -Toke > > > > > > diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c > > > index 951542843cab..a83c4d4326da 100644 > > > --- a/net/sched/sch_cake.c > > > +++ b/net/sched/sch_cake.c > > > @@ -720,7 +720,7 @@ static u32 cake_hash(struct cake_tin_data *q, > > > const struct sk_buff *skb, > > >  skip_hash: > > >         if (flow_override) > > >                 flow_hash = flow_override - 1; > > > -       else if (use_skbhash) > > > +       else if (use_skbhash && flow_mode & CAKE_FLOW_FLOWS) > > >                 flow_hash = skb->hash; > > >         if (host_override) { > > >                 dsthost_hash = host_override - 1; > > > > > >