Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Jamal Hadi Salim" <jhs@mojatatu.com>,
	"Cong Wang" <xiyou.wangcong@gmail.com>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>
Cc: "Jonas Köppeler" <j.koeppeler@tu-berlin.de>,
	cake@lists.bufferbloat.net, netdev@vger.kernel.org,
	"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: [Cake] Re: [PATCH net-next v6 1/6] net/sched: Export mq functions for reuse
Date: Tue, 06 Jan 2026 16:53:03 -0500	[thread overview]
Message-ID: <willemdebruijn.kernel.7b24a60a0a3@gmail.com> (raw)
In-Reply-To: <20260106-mq-cake-sub-qdisc-v6-1-ee2e06b1eb1a@redhat.com>

Toke Høiland-Jørgensen wrote:
> To enable the cake_mq qdisc to reuse code from the mq qdisc, export a
> bunch of functions from sch_mq. Split common functionality out from some
> functions so it can be composed with other code, and export other
> functions wholesale. To discourage wanton reuse, put the symbols into a
> new NET_SCHED_INTERNAL namespace, and a sch_priv.h header file.
> 
> No functional change intended.
> 
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks for revising to reuse the existing mq code, and adding the
symbol namespace.

  reply	other threads:[~2026-01-06 21:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06 11:40 [Cake] [PATCH net-next v6 0/6] Multi-queue aware sch_cake Toke Høiland-Jørgensen
2026-01-06 11:40 ` [Cake] [PATCH net-next v6 1/6] net/sched: Export mq functions for reuse Toke Høiland-Jørgensen
2026-01-06 21:53   ` Willem de Bruijn [this message]
2026-01-06 11:40 ` [Cake] [PATCH net-next v6 2/6] net/sched: sch_cake: Factor out config variables into separate struct Toke Høiland-Jørgensen
2026-01-06 21:57   ` [Cake] " Willem de Bruijn
2026-01-07  9:17     ` Toke Høiland-Jørgensen
2026-01-07 14:42       ` Willem de Bruijn
2026-01-06 11:40 ` [Cake] [PATCH net-next v6 3/6] net/sched: sch_cake: Add cake_mq qdisc for using cake on mq devices Toke Høiland-Jørgensen
2026-01-06 21:57   ` [Cake] " Willem de Bruijn
2026-01-06 11:40 ` [Cake] [PATCH net-next v6 4/6] net/sched: sch_cake: Share config across cake_mq sub-qdiscs Toke Høiland-Jørgensen
2026-01-06 11:40 ` [Cake] [PATCH net-next v6 5/6] net/sched: sch_cake: share shaper state across sub-instances of cake_mq Toke Høiland-Jørgensen
2026-01-06 11:40 ` [Cake] [PATCH net-next v6 6/6] selftests/tc-testing: add selftests for cake_mq qdisc Toke Høiland-Jørgensen
2026-01-06 18:19   ` [Cake] " Victor Nogueira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=willemdebruijn.kernel.7b24a60a0a3@gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=j.koeppeler@tu-berlin.de \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=toke@redhat.com \
    --cc=toke@toke.dk \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox