From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by mail.toke.dk (Postfix) with ESMTPS id 787DEB789C3 for ; Tue, 06 Jan 2026 22:53:06 +0100 (CET) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-78c6a53187dso13766497b3.2 for ; Tue, 06 Jan 2026 13:53:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767736384; x=1768341184; darn=lists.bufferbloat.net; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=J1e3PzBvsbGDQJV4JRdyaBTOtBEIBeMiT97IdIPzaTA=; b=CqnMYtM+H1+9WukpfuzdFoAkv7lUepwMLkOdunyZGId2q+LWF0Gb1In4Tgc/qf+Sux lGWWeBaRMRhyT/RaqqMUJgaYP3QSknqG7EHaGJrSyk7JuqBRaZWaJljiXtcuM+qDHhbM 8XJKLw05G3OO/Lz58gxF5rXjRFzT0Ksk0N4QyKJR+dzvo06MH8qXbgK6NcMStmx9k6kt z22nJDwHAEwqOqDuBu2/JfHkrGXMSUSXzFuUcjNMsSHNkKn6xCl115MkRwS1oLiF8fkD r99jw7n678qKZNHzRKMvR9Kq4H2zHLlDKSw+rDFDtgqcd3K86/xhmD5XJYMeTKAwXpwy wlxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767736384; x=1768341184; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=J1e3PzBvsbGDQJV4JRdyaBTOtBEIBeMiT97IdIPzaTA=; b=qZBBJzkApEeUKhULkmmJm5xxZPcnxt2E7VD081Tws6vwrCdvooLJFwTA1QtTCITwAN Y2Ihd+/e7IHIcGt2OoE8QW+PSuVF2ChcyvZgvsboRx9ohAD8ywOtfdyj+laug+NM9DrL b9pndl0g0y3cP8IDOfvCSK/v5OcV8BwEZ5ssuTJTsjH8kLzcAZ6EM23XSENHW4A/IvDd +WMUACMiMpTqbZN8mnzJ/H6E9JXLV0mwL7UlPKW0GxLJK5Thty7ljoRUF9ZheyLQcYiT X+14t9Bm9/+9nN00xP52QAlFFJzaBqI1TIKVhtZKcZBNHrkW/uMvNBfp/a1Q4uV5hc2R agzQ== X-Forwarded-Encrypted: i=1; AJvYcCX0yH1cx/sV5r5Dt504rjYHgRYQgfOHRNkO59FxCusW+Rme6u1dn7RbXUNx0ayyS99eRn5N@lists.bufferbloat.net X-Gm-Message-State: AOJu0YzJPSNRWPHVB9rMwrkJn4aSH05XBonlNID2ZNTlYDXbOer97F+a wFHBRgJVzazX78mFFp9bdh+0cMZcA5Lj4nxPhlrBgc39AHt37xq8Eudj X-Gm-Gg: AY/fxX5BYXiEnw00qcZrFBZSYxz59rxcnwp75hi0jXyNELjXq5qEKjuFyt8dhP2MDNa pnU4k+9CIgw9Z7+zlHxzPN8JIAjScjBvQVRqx2H/JehNwm/y4TcqzzsB64wCLrVCJYhEUoWlawn jLhLHXYdSGZwCdiZsqThS3CPO0Ct+/UtHJ7CSrnPcgSkYZTnudVtqZqmUHDCSHZzZ0vEtVd6jFe 3Xa67Jtzo7Ih9ZU5KpgSdzIIkZA0t4v5ruf4tgdSP7fgApb7G5XTR8vVzT7GEktLoV4D7wIkpf1 MltQG6EdRYY8u46oZ8RY7yQs4z/JCujf3QJtqJcHuY+fTWi8ny7DneZ2voPyVja+lUrnfd+zMq8 eWRo645HUwp1/xsxC58jh0Mrw4v3ZOO5YUko3tzCsbHudwhZFMH2rR9bAz3RQvI+eIx3GkcT/qy Dq61bXYH7XSKsSTqDW9hyRJ5ex98SHPls7+YD+l5dOFAwEMwZab3rsI6xQMdM= X-Google-Smtp-Source: AGHT+IGjgixfb81YQQySOcMberpQeNF5HhTh7Bj7zc03I1Tkox1NLJa6RxmmanZFBr0SlzFD88cmMw== X-Received: by 2002:a05:690c:4b81:b0:787:d46e:c567 with SMTP id 00721157ae682-790b56d5dc3mr6061037b3.59.1767736384052; Tue, 06 Jan 2026 13:53:04 -0800 (PST) Received: from gmail.com (250.4.48.34.bc.googleusercontent.com. [34.48.4.250]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-790aa553160sm11924677b3.2.2026.01.06.13.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 13:53:03 -0800 (PST) Date: Tue, 06 Jan 2026 16:53:03 -0500 From: Willem de Bruijn To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: =?UTF-8?B?Sm9uYXMgS8O2cHBlbGVy?= , cake@lists.bufferbloat.net, netdev@vger.kernel.org, =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Message-ID: In-Reply-To: <20260106-mq-cake-sub-qdisc-v6-1-ee2e06b1eb1a@redhat.com> References: <20260106-mq-cake-sub-qdisc-v6-0-ee2e06b1eb1a@redhat.com> <20260106-mq-cake-sub-qdisc-v6-1-ee2e06b1eb1a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-MailFrom: willemdebruijn.kernel@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: KHP7JWGHSPUD3KV5MDCCWNGUIFSAJFIS X-Message-ID-Hash: KHP7JWGHSPUD3KV5MDCCWNGUIFSAJFIS X-Mailman-Approved-At: Wed, 07 Jan 2026 09:59:46 +0100 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v6 1/6] net/sched: Export mq functions for reuse List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Toke H=C3=B8iland-J=C3=B8rgensen wrote: > To enable the cake_mq qdisc to reuse code from the mq qdisc, export a > bunch of functions from sch_mq. Split common functionality out from som= e > functions so it can be composed with other code, and export other > functions wholesale. To discourage wanton reuse, put the symbols into a= > new NET_SCHED_INTERNAL namespace, and a sch_priv.h header file. > = > No functional change intended. > = > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen Reviewed-by: Willem de Bruijn Thanks for revising to reuse the existing mq code, and adding the symbol namespace.=