From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-yx1-xb12d.google.com (mail-yx1-xb12d.google.com [IPv6:2607:f8b0:4864:20::b12d]) by mail.toke.dk (Postfix) with ESMTPS id 552CEB7DCCF for ; Wed, 07 Jan 2026 15:42:30 +0100 (CET) Received: by mail-yx1-xb12d.google.com with SMTP id 956f58d0204a3-6420c0cf4abso1922204d50.1 for ; Wed, 07 Jan 2026 06:42:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767796949; x=1768401749; darn=lists.bufferbloat.net; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZpmSZto6HCh21XHSuuIbEddw2MefFg0sEaIgISNXX6I=; b=cycaDonINZhNX/xpoSUh4WE2tFoXCjoqdrbM8Uqs52gURo2ts+M6mGyslVlv1mu6AH CmusQDib5/pY6OtK+u1NCZgSLcKF8naj5+NgmRELe1p4UFVPh0aS8yi4rwgvfBzR3W/j oFfb49v1tfWIFfkvcdjDEHCP4/VaNb6QdLfRFBwba1/XhfHeRhrxdzHY64rYJsra6OnL QDc+ewsYEGfxzOpQz9NRjrAE8J4+LDuupXGiZpW90hlEglpiGNWjWZwNNMkVXXFPt2/3 8ZseZw3r53JG6gbHfV7SJcVqKZMBRfXgJMOBq+30mUghfXOe5ZoDAN2Y3aAykt9pV3th OKbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767796949; x=1768401749; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZpmSZto6HCh21XHSuuIbEddw2MefFg0sEaIgISNXX6I=; b=RNt80C2yF+FV0jswb4sAjwMxt0+CJV1KE0e3/dDP41CocTjngijaujuQaBqyln76u8 SOqkz54EJgv3uYSi3vyofC5NZLouszRdWn4/zR5PWnDJ+SXAxgJw010GTVWii0t8NYa2 I+rveMBMRapKs5D+rE1UUCL6ZCN7nKRSTA+k9ODbrTUKQIbTcBJM1rjSKCh3Ba3tu5ap 2fkDBr0M64bdHf41VrmsjNhfLJD8Ow05JYfwhn7LAakLxBh3v3d+hooDIty2qQVqEokx C8kVxsv1Ds9Fm76yKpaFoGfmd5rOnyD5e2fbtO1OGHDJPbqRGnVFl1rTd0RXbcnpqmT/ 2xuw== X-Forwarded-Encrypted: i=1; AJvYcCXCrNs/TtJIlsA+Ga2NZQjqUM5WFsbRcYZ+CmVJfSe/bmt+QSvjJcExbcElvvk2ZxAYWmY5@lists.bufferbloat.net X-Gm-Message-State: AOJu0YwrPNEr8nyOfYMdVQAvzSBlXpFev971MjOqi35YiInANXVPc6+7 WdCcqM7uJm9YkncQoI4Cu5N2pV1yl8FnCJVYFlwmHf2KgzzIadPllQE3 X-Gm-Gg: AY/fxX5RTJ5FP1A2gE0VUtsa0aqjL1+ZYbqv9Gn5/+m3xiliK5zssPMczqhG2d5iPH5 6tIH0etZlq/u9x+JTrdBd1bPys0C1dIDWLevbpKJ1cOxEaOJ5bf9DuG3ZFtg0QPlNQ6hzWs4pFF f9fJU2ko8ippq9xUzzn2CGPxnOVfJU4/O5erkmk1CseN+E3QGPy5bHX97WjeIXw+sK7wPRZHXT1 nCr7y7/ht067XeTPEpQSFt5iOUYTK1x/gFxNMoCnE4qHRmo4QPtwjaWP6ENFNpXkAe/7CJkgahz yBK/g+YP8KKvB4mRgkfxuJqZ5d6ZMxXpW011A8vvHU2UgIx49x9hxiZWhq+ElzmINIBbhibf0DK Xpzo8AAG/IVuKlOaJmDlV2RLS1C0dEuYqW/tCabyRMroqKbMGHJszR611qYQMZeeiIMY7ZI9Qc/ E6FUctP8iiX5VmSOhljYZHOcuoq0J5AbQAudyB4LoMP4l4b4t4W1ceAbbRb4po1BzHPDMAYw== X-Google-Smtp-Source: AGHT+IHOYqgqIsQV5OCyt+nt3hkI5FRq5tt1UpWArNiIQBGiK3OY9OjfrS8IcPSJ2z64PfeXzfAkwA== X-Received: by 2002:a53:d056:0:20b0:63f:9897:f544 with SMTP id 956f58d0204a3-64716b3a7eamr2055666d50.19.1767796949169; Wed, 07 Jan 2026 06:42:29 -0800 (PST) Received: from gmail.com (250.4.48.34.bc.googleusercontent.com. [34.48.4.250]) by smtp.gmail.com with UTF8SMTPSA id 956f58d0204a3-6470d80dab9sm2133603d50.7.2026.01.07.06.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 06:42:28 -0800 (PST) Date: Wed, 07 Jan 2026 09:42:28 -0500 From: Willem de Bruijn To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Willem de Bruijn , Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: =?UTF-8?B?Sm9uYXMgS8O2cHBlbGVy?= , cake@lists.bufferbloat.net, netdev@vger.kernel.org Message-ID: In-Reply-To: <87jyxt4w9k.fsf@toke.dk> References: <20260106-mq-cake-sub-qdisc-v6-0-ee2e06b1eb1a@redhat.com> <20260106-mq-cake-sub-qdisc-v6-2-ee2e06b1eb1a@redhat.com> <87jyxt4w9k.fsf@toke.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-MailFrom: willemdebruijn.kernel@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: 77SQW6T4QZZ5NSTCUCHNDPBUPJFAGPNE X-Message-ID-Hash: 77SQW6T4QZZ5NSTCUCHNDPBUPJFAGPNE X-Mailman-Approved-At: Wed, 07 Jan 2026 17:16:02 +0100 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v6 2/6] net/sched: sch_cake: Factor out config variables into separate struct List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Willem de Bruijn writes: > = > >> static int cake_init(struct Qdisc *sch, struct nlattr *opt, > >> struct netlink_ext_ack *extack) > >> { > >> - struct cake_sched_data *q =3D qdisc_priv(sch); > >> + struct cake_sched_data *qd =3D qdisc_priv(sch); > >> + struct cake_sched_config *q; > >> int i, j, err; > >> = > >> + q =3D kvcalloc(1, sizeof(struct cake_sched_config), GFP_KERNEL); > >> + if (!q) > >> + return -ENOMEM; > >> + > > > > Can this just be a regular kzalloc? > = > Yeah, I guess so. I'll change this if there's a need to respin for othe= r > reasons, but probably not worth respinning for this on its own? Seeing > as it'll all end up in the same kmalloc call anyway :) Sounds good. > = > > More importantly, where is q assigned to qd->config after init? > = > Just below: > = > >> sch->limit =3D 10240; > >> sch->flags |=3D TCQ_F_DEQUEUE_DROPS; > >> = > >> @@ -2742,33 +2755,36 @@ static int cake_init(struct Qdisc *sch, stru= ct nlattr *opt, > >> * for 5 to 10% of interval > >> */ > >> q->rate_flags |=3D CAKE_FLAG_SPLIT_GSO; > >> - q->cur_tin =3D 0; > >> - q->cur_flow =3D 0; > >> + qd->cur_tin =3D 0; > >> + qd->cur_flow =3D 0; > >> + qd->config =3D q; > = > Here: ^^^^^^^ I'm blind. Thanks! Reviewed-by: Willem de Bruijn