Historic archive of defunct list cerowrt-commits@lists.bufferbloat.net
 help / color / mirror / Atom feed
From: GitHub <noreply@github.com>
To: cerowrt-commits@lists.bufferbloat.net
Subject: [dtaht/ceropackages-3.3] 97272f: aqm-scripts: Fix simplest.qos DOWNLINK
Date: Mon, 20 May 2013 01:51:25 -0700	[thread overview]
Message-ID: <5199e40dc988a_2bff1135dd433794@hookshot-fe4-pe1-prd.aws.github.net.mail> (raw)

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

  Branch: refs/heads/master
  Home:   https://github.com/dtaht/ceropackages-3.3
  Commit: 97272f46fde71652a449bf73fd5d672b8a137331
      https://github.com/dtaht/ceropackages-3.3/commit/97272f46fde71652a449bf73fd5d672b8a137331
  Author: Dave Taht <dave.taht@bufferbloat.net>
  Date:   2013-05-20 (Mon, 20 May 2013)

  Changed paths:
    M net/aqm-scripts/files/usr/lib/aqm/simplest.qos

  Log Message:
  -----------
  aqm-scripts: Fix simplest.qos DOWNLINK

I goofed in making simplest.qos as simple as possible in that I
leveraged the CEIL variable, which no longer exists, and worse,
only tested it in a symmetric scenario which didn't expose the
problem.

Also r2q is just plain wrong and needs to be calculated correctly
as per

http://www.mail-archive.com/lartc@mailman.ds9a.nl/msg13343.html

Bu the math makes my head hurt and I'd rather aim for the lowest
latency/best mixing default rather than one that was computationally
cheap, because it's computationally cheap anyway.

So haven't fixed that yet.




                 reply	other threads:[~2013-05-20  8:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5199e40dc988a_2bff1135dd433794@hookshot-fe4-pe1-prd.aws.github.net.mail \
    --to=noreply@github.com \
    --cc=cerowrt-commits@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox