From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m71-131.mailgun.net (m71-131.mailgun.net [166.78.71.131]) by huchra.bufferbloat.net (Postfix) with ESMTP id A5FA921F14E for ; Sun, 5 Oct 2014 15:01:45 -0700 (PDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=github.com; q=dns/txt; s=mailo; t=1412546504; h=Date: From: Reply-To: To: Message-Id: Subject: Mime-Version: Content-Type: Content-Transfer-Encoding: Sender; bh=AWLAGQy3NWrnEbfY7yq73Y1RUhpM3LfGKoEuPJA0y78=; b=YiNA0Tl3GhmJUdSWyresKxT1G5rQ2bntIOD87ws93V0SMkwatnVGkOEFTs/gNM7DZtzSabFd 8AiIgbnmLvntMAbtHWZ/Si29kEaFO+GJ7u71hBEngVNYucKWAOyVl1PiSQ86tQFOVVTs+qj4 sW7DIbb7SRXh1x6NMBtmttjM5s8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=github.com; s=mailo; q=dns; h=Date: From: Reply-To: To: Message-Id: Subject: Mime-Version: Content-Type: Content-Transfer-Encoding: Sender; b=yhCajuzkJAurYHOBDHZKPi5dyLsCWSXXUiCuKWorxhUyRdWnT4cZi7oFfbP6wZyMAmsa/D It3On0bevo+y0WQ2VtbFiw7lrmRKdMxW/OkGFCWm1bx6aNF1Wlweuwl3DY85cP7f7vyN5Ru4 foW/WZ7OJ5qXHgKc0bOOcPzOTodwU= Received: from github.com (Unknown [192.30.252.41]) by mxa.mailgun.org with ESMTP id 5431bfc0.a70ed20-in3; Sun, 05 Oct 2014 22:01:36 -0000 (UTC) Date: Sun, 05 Oct 2014 15:01:36 -0700 From: GitHub To: cerowrt-commits@lists.bufferbloat.net Message-Id: <5431bfc04d3b4_a0c3fd5fdc9d2a0101866@hookshot-fe3-cp1-prd.iad.github.net.mail> Subject: [dtaht/ceropackages-3.10] 8e4214: Switch SQM to use named IFB devices instead if ifb... Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="--==_mimepart_5431bfc04ce56_a0c3fd5fdc9d2a0101720"; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailgun-Sid: WyIzOWVlZSIsICJjZXJvd3J0LWNvbW1pdHNAbGlzdHMuYnVmZmVyYmxvYXQubmV0IiwgIjQwZiJd Sender: noreply@github.com X-BeenThere: cerowrt-commits@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list Reply-To: GitHub List-Id: Development commits for the cerowrt project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Oct 2014 22:02:14 -0000 ----==_mimepart_5431bfc04ce56_a0c3fd5fdc9d2a0101720 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Branch: refs/heads/master Home: https://github.com/dtaht/ceropackages-3.10 Commit: 8e42148c5f6456928d712c5e70d35d7e28ea2115 https://github.com/dtaht/ceropackages-3.10/commit/8e42148c5f6456928d712c5e70d35d7e28ea2115 Author: Sebastian Moeller Date: 2014-10-05 (Sun, 05 Oct 2014) Changed paths: M net/sqm-scripts/files/usr/lib/sqm/functions.sh Log Message: ----------- Switch SQM to use named IFB devices instead if ifb0 to ifbN Generic indexed ifb devices are somewhat inflexible in that it is hard to find which interface a given ifbN is assiciated to (if any at all). Since SQM wants to avoid interfering with other users if IFBs on cerowrt and potentially openwrt as well, we switch to named ifb devices. It will be much harder for a user to accidentally create IFB names similar to our scheme (currently: "ifb4${DEV_NAME_OF_ASSOCIATED_INTERFACE}"). Also SQM will most likely not go wild and ceate to many indexed IFBs as has been noticed in the wild with the old implementation. Ideally we would use a scheme like "ifb_SQM_${DEV_NAME_OF_ASSOCIATED_INTERFACE}" BUT IFB names need to be no longer than 15 characters and with unwieldly interface names as pppoe-ge00 that scheme does not really work.... For to long interface names the new implementation will chop off the extra characters from the beginning of the interface names, under the assumption that the identifying characters are at the end (based on pppoe-ge00). For now we leave the old function in place that tries to find the lowest unused indexed ifb name, but if the new implementation survives some testing that ugly function can be deleted... WARNING while this works for me it is only lightly tested and needs EYEBALLS badly, please help out if you can... Also this patch reorders some variables in funcrtions.sh. ----==_mimepart_5431bfc04ce56_a0c3fd5fdc9d2a0101720--