From: GitHub <noreply@github.com>
To: cerowrt-commits@lists.bufferbloat.net
Subject: [dtaht/ceropackages-3.10] f8a824: sqm-scripts: change default for qdisc target param...
Date: Fri, 20 Mar 2015 14:24:29 -0700 [thread overview]
Message-ID: <550c900dda971_1d753fd9aa2892b8251fe@hookshot-fe1-cp1-prd.iad.github.net.mail> (raw)
[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]
Branch: refs/heads/master
Home: https://github.com/dtaht/ceropackages-3.10
Commit: f8a8243a1c988eb82246a7551c71c7b44508a7ba
https://github.com/dtaht/ceropackages-3.10/commit/f8a8243a1c988eb82246a7551c71c7b44508a7ba
Author: Sebastian Moeller <moeller0@gmx.de>
Date: 2015-03-20 (Fri, 20 Mar 2015)
Changed paths:
M luci/luci-app-sqm/files/sqm-cbi.lua
M net/sqm-scripts/files/usr/lib/sqm/functions.sh
Log Message:
-----------
sqm-scripts: change default for qdisc target parameter
Alan Jenkins noted a bug in the smq luci GUI that effectively
erased several configuration paramters if two checkboxes were deselected.
This behaviour seems consistent in luci but certainly has the potential
to confuse users. While confusion can not really be avoided generally
it seems wise to change the default interpretation for empty or non-existent
itarget and etarget variables from the qdisc's default (5ms in the case of
one of the codels) to automatic determination of tghis variable dependent on
the configured bandwidth, as codels target variable should be large enough
to contain at least one full packet. With this change sqm-scripts will
do the right thing by default, but will yet allow the user to specify
over-ridding values (as long as the user does not un-check the
entry-field exposing check boxes). Survives light testing...
This change set also changes the sqm-scripts luci gui to note the user
of the change. For compatibility with existing setups sqm-scripts
will still honor "auto" as an alternative explicit way of requesting
automatic target selection. This might turn into a warning in the future
and might be phased out...
Signed-off-by: Sebastian Moeller <moeller0@gmx.de>
reply other threads:[~2015-03-20 21:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550c900dda971_1d753fd9aa2892b8251fe@hookshot-fe1-cp1-prd.iad.github.net.mail \
--to=noreply@github.com \
--cc=cerowrt-commits@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox