Branch: refs/heads/master Home: https://github.com/dtaht/ceropackages-3.10 Commit: f8a8243a1c988eb82246a7551c71c7b44508a7ba https://github.com/dtaht/ceropackages-3.10/commit/f8a8243a1c988eb82246a7551c71c7b44508a7ba Author: Sebastian Moeller Date: 2015-03-20 (Fri, 20 Mar 2015) Changed paths: M luci/luci-app-sqm/files/sqm-cbi.lua M net/sqm-scripts/files/usr/lib/sqm/functions.sh Log Message: ----------- sqm-scripts: change default for qdisc target parameter Alan Jenkins noted a bug in the smq luci GUI that effectively erased several configuration paramters if two checkboxes were deselected. This behaviour seems consistent in luci but certainly has the potential to confuse users. While confusion can not really be avoided generally it seems wise to change the default interpretation for empty or non-existent itarget and etarget variables from the qdisc's default (5ms in the case of one of the codels) to automatic determination of tghis variable dependent on the configured bandwidth, as codels target variable should be large enough to contain at least one full packet. With this change sqm-scripts will do the right thing by default, but will yet allow the user to specify over-ridding values (as long as the user does not un-check the entry-field exposing check boxes). Survives light testing... This change set also changes the sqm-scripts luci gui to note the user of the change. For compatibility with existing setups sqm-scripts will still honor "auto" as an alternative explicit way of requesting automatic target selection. This might turn into a warning in the future and might be phased out... Signed-off-by: Sebastian Moeller