From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m69-169.mailgun.net (m69-169.mailgun.net [166.78.69.169]) by huchra.bufferbloat.net (Postfix) with ESMTP id C183F21F3EA for ; Fri, 20 Mar 2015 14:24:32 -0700 (PDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=github.com; q=dns/txt; s=mailo; t=1426886671; h=Sender: Content-Transfer-Encoding: Content-Type: Mime-Version: Subject: Message-Id: To: Reply-To: From: Date; bh=UxbRutI18ALh1IjJVqSE3p7e/9PD0sQ1SlwajG/f/Ks=; b=oK50ABIFmC01P0ajGMRVFURnutokRgcut1CoCXkIqAwDFiUxOFaefxOhgq6TECb+Swmxzcu5 q6yaIMRjxCX+decEOXT/RDOYcL08LxIVv9Z042I+XnoWq0obRX/lBf1CzzOBTlVmtc3BNA/J BwakNGnFdX5nenyaGgjKOnhU6yY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=github.com; s=mailo; q=dns; h=Date: From: Reply-To: To: Message-Id: Subject: Mime-Version: Content-Type: Content-Transfer-Encoding: Sender; b=XXJ6UD5kLEqg/4nQGePl75sDeZkS0xrLt7KEGCIjJKFAQBCpoRt/195mG3trXhcyyUWxBF CoTksp/5W5N+muUpQ4FTe3uxck19lQn8aC8ls5dTXtUTh+gUOk4q3bpUTSlFLil5oo8DPt60 sZ2UbnIHfghAx2mSiaImJmaFWTS3I= Received: from github.com (Unknown [192.30.252.42]) by mxa.mailgun.org with ESMTP id 550c900d.7fd9e4d488a0-in01; Fri, 20 Mar 2015 21:24:29 -0000 (UTC) Date: Fri, 20 Mar 2015 14:24:29 -0700 From: GitHub To: cerowrt-commits@lists.bufferbloat.net Message-Id: <550c900dda971_1d753fd9aa2892b8251fe@hookshot-fe1-cp1-prd.iad.github.net.mail> Subject: [dtaht/ceropackages-3.10] f8a824: sqm-scripts: change default for qdisc target param... Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="--==_mimepart_550c900dda3ce_1d753fd9aa2892b825085"; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailgun-Sid: WyIzOWVlZSIsICJjZXJvd3J0LWNvbW1pdHNAbGlzdHMuYnVmZmVyYmxvYXQubmV0IiwgIjQwZiJd Sender: noreply@github.com X-BeenThere: cerowrt-commits@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list Reply-To: GitHub List-Id: Development commits for the cerowrt project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 21:25:01 -0000 ----==_mimepart_550c900dda3ce_1d753fd9aa2892b825085 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Branch: refs/heads/master Home: https://github.com/dtaht/ceropackages-3.10 Commit: f8a8243a1c988eb82246a7551c71c7b44508a7ba https://github.com/dtaht/ceropackages-3.10/commit/f8a8243a1c988eb82246a7551c71c7b44508a7ba Author: Sebastian Moeller Date: 2015-03-20 (Fri, 20 Mar 2015) Changed paths: M luci/luci-app-sqm/files/sqm-cbi.lua M net/sqm-scripts/files/usr/lib/sqm/functions.sh Log Message: ----------- sqm-scripts: change default for qdisc target parameter Alan Jenkins noted a bug in the smq luci GUI that effectively erased several configuration paramters if two checkboxes were deselected. This behaviour seems consistent in luci but certainly has the potential to confuse users. While confusion can not really be avoided generally it seems wise to change the default interpretation for empty or non-existent itarget and etarget variables from the qdisc's default (5ms in the case of one of the codels) to automatic determination of tghis variable dependent on the configured bandwidth, as codels target variable should be large enough to contain at least one full packet. With this change sqm-scripts will do the right thing by default, but will yet allow the user to specify over-ridding values (as long as the user does not un-check the entry-field exposing check boxes). Survives light testing... This change set also changes the sqm-scripts luci gui to note the user of the change. For compatibility with existing setups sqm-scripts will still honor "auto" as an alternative explicit way of requesting automatic target selection. This might turn into a warning in the future and might be phased out... Signed-off-by: Sebastian Moeller ----==_mimepart_550c900dda3ce_1d753fd9aa2892b825085--