From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m69-169.mailgun.net (m69-169.mailgun.net [166.78.69.169]) by huchra.bufferbloat.net (Postfix) with ESMTP id 5939821F504 for ; Sun, 19 Apr 2015 03:39:03 -0700 (PDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=github.com; q=dns/txt; s=mailo; t=1429439942; h=Sender: Content-Transfer-Encoding: Content-Type: Mime-Version: Subject: Message-Id: To: Reply-To: From: Date; bh=DpYEe9PObpUtrM4/dx8ZVKv9Nbwy/1DEWTqptz8Mk54=; b=LQcZJK4I9TPpEO5/jHluJj99S0278FXXZpNc8hwUijidKa+7k+FeOMSCrgp2hT6lq9niCVW2 fB48vzNPJ9X829nZJwf12wEwu+WoZa/w7/LwqMLqeiGWjm3eagFM4uKReRGfhOEXjIKlbs6F 9PywzhB51p3Bt2P+OePiT8+7JLI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=github.com; s=mailo; q=dns; h=Date: From: Reply-To: To: Message-Id: Subject: Mime-Version: Content-Type: Content-Transfer-Encoding: Sender; b=BPzu57kOw3AU/sDojaM0eGMpN9zB4v0e1Jlmdh70GOEbzL08EWddppaSg+ZAIZVXyOwtS0 msG+ypc2+XlN8LYCMfyT/p2xEvJYbLQK5rxw620QmmFc1MxrTGgewcI25hnkkBadewsIH2Ze +cI2j1lBtcj2d1WQVdT+6b5CqCNm4= Received: from github.com (Unknown [192.30.252.45]) by mxa.mailgun.org with ESMTP id 553385c6.5d817e0-in01; Sun, 19 Apr 2015 10:39:02 -0000 (UTC) Date: Sun, 19 Apr 2015 03:39:02 -0700 From: GitHub To: cerowrt-commits@lists.bufferbloat.net Message-Id: <553385c6776fb_16593f8d3a0272c0448b8@hookshot-fe3-cp1-prd.iad.github.net.mail> Subject: [dtaht/ceropackages-3.10] 916e72: [sqm-scripts] remove unused dependency from Makefi... Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="--==_mimepart_553385c6772c6_16593f8d3a0272c044717"; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailgun-Sid: WyIzOWVlZSIsICJjZXJvd3J0LWNvbW1pdHNAbGlzdHMuYnVmZmVyYmxvYXQubmV0IiwgIjQwZiJd Sender: noreply@github.com X-BeenThere: cerowrt-commits@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list Reply-To: GitHub List-Id: Development commits for the cerowrt project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2015 10:39:32 -0000 ----==_mimepart_553385c6772c6_16593f8d3a0272c044717 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Branch: refs/heads/master Home: https://github.com/dtaht/ceropackages-3.10 Commit: 916e72031e70393e8a09962743b69a53ee5a1eb2 https://github.com/dtaht/ceropackages-3.10/commit/916e72031e70393e8a09962743b69a53ee5a1eb2 Author: Sebastian Moeller Date: 2015-04-19 (Sun, 19 Apr 2015) Changed paths: M net/sqm-scripts/Makefile Log Message: ----------- [sqm-scripts] remove unused dependency from Makefile Hnyman reported the following: "I noticed unnecessary layer7 files on my router and started investigating bit. It looks like both qos-scripts and sqm-scripts included those files unnecessarily. Openwrt bug: https://dev.openwrt.org/ticket/19506 Nbd has already fixed iptables and qos-scripts (and indirectly also sqm, as those files were removed from iptables), but I think that SQM may still have unnecessary dependencies: for iptables-mod-filter and possibly also for iptables-mod-conntrack-extra. Those dependencies originate from the original import of qos-scripts to cerowrt as the basis for the new "aqm-scripts", current SQM: bc8363c iptables-mod-filter (and kmod-ipt-filter) currently define only packet content string matching. The filter package also pulls in kmod-lib-textsearch, adding to the size. To my knowledge, the string matching is not used in SQM. https://dev.openwrt.org/browser/trunk/package/network/utils/iptables/Makefile#L117 https://dev.openwrt.org/browser/trunk/package/kernel/linux/modules/netfilter.mk#L163 https://dev.openwrt.org/browser/trunk/include/netfilter.mk#L101 Similarly, iptables-mod-conntrack-extra defines "Matches: - connbytes, - connlimit, - connmark, - recent, - helper" and "Targets - CONNMARK". I don't think that they are used in SQM. (CONNMARK is used by qos, so it is needed there) https://dev.openwrt.org/browser/trunk/package/network/utils/iptables/Makefile#L97 https://dev.openwrt.org/browser/trunk/package/kernel/linux/modules/netfilter.mk#L142 https://dev.openwrt.org/browser/trunk/include/netfilter.mk#L80 dcsp, tos are defined in "iptables-mod-ipopt", while MARK target is in core iptables. https://dev.openwrt.org/browser/trunk/include/netfilter.mk#L106 https://dev.openwrt.org/browser/trunk/include/netfilter.mk#L61 So, I don't see a need for iptables-mod-filter and iptables-mod-conntrack-extra in SQM. Or at least the need for them is not immediately visible in the source. I haven't yet tested very deeply, but removing the iptables-mod-filter from my current build did not cause any problems. I am no netfilter/iptables expert, but though to highlight the possible bloat to the devs." This commit removes iptables-mod-filter, iptables-mod-conntrack-extra requires more research before removal. ----==_mimepart_553385c6772c6_16593f8d3a0272c044717--