[dtaht/ceropackages-3.10] 916e72: [sqm-scripts] remove unused dependency from Makefi...

[dtaht/ceropackages-3.10] 916e72: [sqm-scripts] remove unused dependency from Makefi...

[GitHub]

[-- Attachment #1: Type: text/plain, Size: 2718 bytes --]

  Branch: refs/heads/master
  Home:   https://github.com/dtaht/ceropackages-3.10
  Commit: 916e72031e70393e8a09962743b69a53ee5a1eb2
      https://github.com/dtaht/ceropackages-3.10/commit/916e72031e70393e8a09962743b69a53ee5a1eb2
  Author: Sebastian Moeller <moeller0@gmx.de>
  Date:   2015-04-19 (Sun, 19 Apr 2015)

  Changed paths:
    M net/sqm-scripts/Makefile

  Log Message:
  -----------
  [sqm-scripts] remove unused dependency from Makefile

Hnyman reported the following:
"I noticed unnecessary layer7 files on my router and started investigating bit.
It looks like both qos-scripts and sqm-scripts included those files unnecessarily.
Openwrt bug: https://dev.openwrt.org/ticket/19506

Nbd has already fixed iptables and qos-scripts (and indirectly also sqm, as those
files were removed from iptables), but I think that SQM may still have unnecessary
dependencies: for iptables-mod-filter and possibly also for iptables-mod-conntrack-extra.

Those dependencies originate from the original import of qos-scripts to cerowrt as
the basis for the new "aqm-scripts", current SQM: bc8363c

iptables-mod-filter (and kmod-ipt-filter) currently define only packet content
string matching. The filter package also pulls in kmod-lib-textsearch, adding to
the size. To my knowledge, the string matching is not used in SQM.

https://dev.openwrt.org/browser/trunk/package/network/utils/iptables/Makefile#L117
https://dev.openwrt.org/browser/trunk/package/kernel/linux/modules/netfilter.mk#L163
https://dev.openwrt.org/browser/trunk/include/netfilter.mk#L101

Similarly, iptables-mod-conntrack-extra defines "Matches: - connbytes, - connlimit,
- connmark, - recent, - helper" and "Targets - CONNMARK".
I don't think that they are used in SQM. (CONNMARK is used by qos, so it is needed there)

https://dev.openwrt.org/browser/trunk/package/network/utils/iptables/Makefile#L97
https://dev.openwrt.org/browser/trunk/package/kernel/linux/modules/netfilter.mk#L142
https://dev.openwrt.org/browser/trunk/include/netfilter.mk#L80

dcsp, tos are defined in "iptables-mod-ipopt", while MARK target is in core iptables.
https://dev.openwrt.org/browser/trunk/include/netfilter.mk#L106
https://dev.openwrt.org/browser/trunk/include/netfilter.mk#L61

So, I don't see a need for iptables-mod-filter and iptables-mod-conntrack-extra in SQM. Or at least the need for them is not immediately visible in the source. I haven't yet tested very deeply, but removing the iptables-mod-filter from my current build did not cause any problems.

I am no netfilter/iptables expert, but though to highlight the possible bloat to the devs."

This commit removes iptables-mod-filter, iptables-mod-conntrack-extra requires more research before
removal.