From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 4B43721F265 for ; Mon, 16 Feb 2015 15:23:56 -0800 (PST) Received: from hms-beagle.home.lan ([217.237.85.64]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0M4B71-1XWV5f0GMl-00rp5X; Tue, 17 Feb 2015 00:23:52 +0100 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Moeller In-Reply-To: <87lhjz1739.fsf@toke.dk> Date: Tue, 17 Feb 2015 00:23:47 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <0A2B8259-3BCB-4589-8BAB-9E01C62431DE@gmx.de> References: <54E0AFB2.5040806@gmail.com> <87vbj3i5hz.fsf@toke.dk> <87r3tri2x3.fsf@toke.dk> <9EB28655-6E25-470B-A13B-036EE00D84D7@gmx.de> <87lhjz1739.fsf@toke.dk> To: =?windows-1252?Q?Toke_H=F8iland-J=F8rgensen?= X-Mailer: Apple Mail (2.1878.6) X-Provags-ID: V03:K0:4mTsVHDyPjJ1o/vR8cQ5cmlBOoSK5AuxspeDi+j6GUtipFPGW9D gWaidWZyaU/6769U3H1Sj6aPu6JTmVMA889RrqSW5UhZa9Grk5ESiklTqzm58bRE8GzXGY+ DOMD+s+8s0iVWseqzYplWhEyhC48Bl+TCA95MWfZKMjzEv8+8AkbUHdzfp6hgITpiU5n4GO FTDlGGb3CGJHRuZAT2auQ== X-UI-Out-Filterresults: notjunk:1; Cc: Alan Jenkins , openwrt-devel , luis@bitamins.net, cerowrt-devel@lists.bufferbloat.net Subject: Re: [Cerowrt-devel] [sqm-scripts] not started at boot? X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 23:24:26 -0000 Hi Toke, hi Alan, On Feb 15, 2015, at 17:18 , Toke H=F8iland-J=F8rgensen = wrote: > Sebastian Moeller writes: >=20 >> Not that I have shown great taste in the past, but I think it >> would be somewhat cleaner to put the logic into the hot plug script >> and keep run.sh =93simple=94 (in the past I had introduced a large = number >> of leakage, especially of IFBs by not properly removing/stopping old >> instances and was quite happy to have the take all active interfaces >> down loop as a last defense against accidental leaks). >=20 > Well, the biggest issue I can see with not having any logic in run.sh = is > that in that case, *all* interfaces will be reconfigured when the > hotplug event happens. However, I'm not sure exactly how common it is = to > have more than one interface configured for SQM, and if so, whether or > not reconfiguring everything on every hotplug event (well, only for = for > SQM-enabled interfaces I suppose) is an issue. >=20 > The modifications to run.sh should keep it functioning the way it does > currently if run 'manually' the shell or LUCI. Unless the $DEVICE > env-var is set for some other reason... >=20 >=20 >> But I am now also running pppoe directly from cerowrt and see >> the same issue, sqm is confused when the pppoe interface >> temporarily goes away, so at least I can now test this issue ;) >=20 > Well, a first pass could be to see if the modified run.sh I sent last > time around actually works... ;) While I just had enough time to test this, and on my cerowrt = 3.10.50-1 this (in addition to Alan=92s hotplug script) does not seem to = properly restart SQM over a pppoe reconnect. I will need to find a bit = more time to figure out where I misconfigured my system as I expect I = should be able to recreate Alan=92s success. But this means it will take = me even longer to try to improve SQM=92s smarts about what to restart=85 Best Regards Sebastian >=20 > -Toke