From: "Dave Täht" <dave.taht@bufferbloat.net>
To: edumazet@google.com, cerowrt-devel@lists.bufferbloat.net
Subject: [Cerowrt-devel] [PATCH] skb_reduce_truesize: helper function for shrinking skbs whenever needed
Date: Mon, 31 Dec 2012 10:08:05 -0800 [thread overview]
Message-ID: <1356977285-12964-1-git-send-email-dave.taht@bufferbloat.net> (raw)
From: Dave Taht <dave.taht@bufferbloat.net>
On embedded devices in particular, large queues of small packets from the rx
path with a large truesize can exist. Reducing their size can reduce
memory pressure. skb_reduce_truesize is a helper function for doing this,
when needed.
---
include/linux/skbuff.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 6a2c34e..2080cb1 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1671,6 +1671,24 @@ static inline void pskb_trim_unique(struct sk_buff *skb, unsigned int len)
BUG_ON(err);
}
+/*
+ * Caller wants to reduce memory needs before queueing skb
+ * The (expensive) copy should not be be done in fast path.
+ */
+static inline struct sk_buff *skb_reduce_truesize(struct sk_buff *skb)
+{
+ if (skb->truesize > 2 * SKB_TRUESIZE(skb->len)) {
+ struct sk_buff *nskb;
+ nskb = skb_copy_expand(skb, skb_headroom(skb), 0,
+ GFP_ATOMIC | __GFP_NOWARN);
+ if (nskb) {
+ __kfree_skb(skb);
+ skb = nskb;
+ }
+ }
+ return skb;
+}
+
/**
* skb_orphan - orphan a buffer
* @skb: buffer to orphan
--
1.7.9.5
next reply other threads:[~2012-12-31 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 18:08 Dave Täht [this message]
2012-12-31 18:14 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356977285-12964-1-git-send-email-dave.taht@bufferbloat.net \
--to=dave.taht@bufferbloat.net \
--cc=cerowrt-devel@lists.bufferbloat.net \
--cc=edumazet@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox