Re: [Cerowrt-devel] some kernel updates

[Jesper Dangaard Brouer <jbrouer@redhat.com>]

On Fri, 23 Aug 2013 13:29:25 -0700
Dave Taht <dave.taht@gmail.com> wrote:

> Does anyone have a date/kernel version on when linklayer overhead
> compensation stopped working?

ADSL/ATM linklayer shaping were broken in kernel release from 3.8 to
3.10 by commit 56b765b79 ("htb: improved accuracy at high rates") in
v3.8-rc1~139^2~455.

> There was a bug even prior to 3.8 that looked bad.

Eric Dumazet also found a general "linklayer atm" regression
(dating way-back), which could cause rate-tables to get wrongly shared
between the same rates with-and-without linklayer atm settings.

Addressed/fixed in (3.10-rc6:):
 - commit 40edeff6e1c (net_sched: qdisc_get_rtab() must check data[] array)

When configuring two completely equal rates, the kernel detects that
these two equal rates can share the same rate-table.  But the kernel
didn't check if the rate-table data had been modified, which is done
in the linklayer atm case.

In practice, this often isn't a problem, as overhead parameter is
usually combined with the linklayer parameter.

See my description here:
 http://thread.gmane.org/gmane.linux.kernel.stable/62528

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer