Maybe attached patch is more comprehensive? KDB > On 21 Aug 2019, at 16:07, Dave Taht wrote: > > Just ressurrecting this old thread for review now that this is an > official RFC. I note also that the NQB diffserv codepoint is entering > last call also. > > https://tools.ietf.org/html/draft-white-tsvwg-nqb-02 > > On Sun, Feb 3, 2019 at 10:39 AM Dave Taht wrote: >> >> And seems likely to be adopted. >> >> There seems to be an urge to make this codepoint starvable, which >> since I ascribe to nagle's dictum "every application has a right to >> one packet in the network" - doesn't work for me - but the draft is >> vaguely worded enough to just start dumping this codepoint into the >> background queue of both sqm and cake and worry about it in a decade >> or three. >> >> it's 000001 which I guess is: >> >> diff --git a/sch_cake.c b/sch_cake.c >> index 3a26db0..67263b3 100644 >> --- a/sch_cake.c >> +++ b/sch_cake.c >> @@ -343,7 +343,7 @@ static const u8 diffserv4[] = { >> }; >> >> static const u8 diffserv3[] = { >> - 0, 0, 0, 0, 2, 0, 0, 0, >> + 0, 1, 0, 0, 2, 0, 0, 0, >> 1, 0, 0, 0, 0, 0, 0, 0, >> 0, 0, 0, 0, 0, 0, 0, 0, >> 0, 0, 0, 0, 0, 0, 0, 0, >> >> (or is that reversed? my big endian/little endian chops scuks, and >> nobody modified the gen_cake_const tool to match what cake expects >> now) >> >> on my off days I kind of wish the diffserv lookup we do in cake had >> managed to make it into the linux mqprio/prio stuff by default. >> >> -- >> >> Dave Täht >> CTO, TekLibre, LLC >> http://www.teklibre.com >> Tel: 1-831-205-9740 > > > > -- > > Dave Täht > CTO, TekLibre, LLC > http://www.teklibre.com > Tel: 1-831-205-9740 > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake Cheers, Kevin D-B gpg: 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A