From: Sebastian Moeller <moeller0@gmx.de>
To: Alan Jenkins <alan.christopher.jenkins@gmail.com>
Cc: cerowrt-devel@lists.bufferbloat.net
Subject: Re: [Cerowrt-devel] [sqm-scripts] not started at boot?
Date: Tue, 3 Mar 2015 18:06:35 +0100 [thread overview]
Message-ID: <33C677EE-26CD-4F46-89A1-3E47702AEA5E@gmx.de> (raw)
In-Reply-To: <54E0CA64.7000101@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
Hi Alan,
I would be delighted if you could try the etc/hotplug.d/iface/11-sqm and the updated usr/lib/sqm/run.sh from the attached files (I am not sure about the root to the files in the attached folder, but you will figure it out, I am sure ;) ). This should fix the reconnect when pop interface transiently go away issue. I am not sure whether this fixes the startup after reboot issue, so please feel free to test this as well.
Best Regards
Sebastian
[-- Attachment #2: sqm-scripts.zip --]
[-- Type: application/zip, Size: 27418 bytes --]
[-- Attachment #3: Type: text/plain, Size: 1382 bytes --]
On Feb 15, 2015, at 17:33 , Alan Jenkins <alan.christopher.jenkins@gmail.com> wrote:
>
> On 15/02/15 15:56, Toke Høiland-Jørgensen wrote:
>> Sebastian Moeller <moeller0@gmx.de> writes:
>>
>>> I am not sure that this works as intended. The first thing
>>> run.sh does is take down all running SQM instances:
>> Ah yes, seems I was a bit too trigger-happy there ;)
> I was just about to explain the same, after testing it :). (I have more interfaces coming up after pppoe-wan, so SQM stops immediately after it's started)
>
>> Here's a version of run.sh that should also short-circuit the 'down'
>> part if called from hotplug.
> Yep. that version works ok.
>
>> The alternative is, of course, to have logic in the hotplug script to
>> only call run.sh for interfaces that are enabled, but that would require
>> parsing /etc/config/sqm from there. My initial thought was that
>> short-circuiting the logic in run.sh was 'cleaner'; but I'm not entirely
>> sure about that... Thoughts?
>>
>> -Toke
>
> It's a small tweak, but maybe the argument to run.sh could be made explicit.
>
> run.sh start $DEVICE # specific device
> run.sh # all devices
>
> Regards
> Alan
> _______________________________________________
> Cerowrt-devel mailing list
> Cerowrt-devel@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cerowrt-devel
next prev parent reply other threads:[~2015-03-03 17:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 14:39 Alan Jenkins
2015-02-15 15:00 ` Toke Høiland-Jørgensen
2015-02-15 15:48 ` Sebastian Moeller
2015-02-15 15:56 ` Toke Høiland-Jørgensen
2015-02-15 16:12 ` Sebastian Moeller
2015-02-15 16:18 ` Toke Høiland-Jørgensen
2015-02-16 23:23 ` Sebastian Moeller
2015-02-15 16:33 ` Alan Jenkins
2015-02-16 9:05 ` Sebastian Moeller
2015-03-03 17:06 ` Sebastian Moeller [this message]
2015-03-03 21:23 ` Alan Jenkins
2015-03-03 21:27 ` Toke Høiland-Jørgensen
2015-03-03 21:35 ` Sebastian Moeller
2015-03-03 22:39 ` Alan Jenkins
2015-03-03 22:46 ` Sebastian Moeller
2015-02-15 16:16 ` Sebastian Moeller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33C677EE-26CD-4F46-89A1-3E47702AEA5E@gmx.de \
--to=moeller0@gmx.de \
--cc=alan.christopher.jenkins@gmail.com \
--cc=cerowrt-devel@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox