From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 3110021FC5E for ; Mon, 29 Jun 2015 01:10:08 -0700 (PDT) Received: from u-089-d065.biologie.uni-tuebingen.de ([134.2.89.65]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0Lusmr-1Z0ifE1ikL-0107VL; Mon, 29 Jun 2015 10:10:05 +0200 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Moeller In-Reply-To: Date: Mon, 29 Jun 2015 10:10:14 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <38885792-08BD-4D7E-9838-9F5E0BED34DB@gmx.de> References: <8B853F1C-DE5D-4F3D-88CC-CB8DA2D3E8B1@gmx.de> <04331509-F163-4184-90B4-8589073AFD62@gmx.de> <09BA156C-460D-4794-A082-33E805F3D6FD@gmx.de> <5436B48C-0803-46DA-B355-14E917A5BB37@gmx.de> To: Mikael Abrahamsson X-Mailer: Apple Mail (2.1878.6) X-Provags-ID: V03:K0:dYv9ZXmK5Z5KmDPqla8InfaTxuOg+gYDr03vcfCcKKTCtW5Gyjb u+E7LqxSzZ4cug0JQkzuYsh2P4zWXIqufb3BoFvmSwaIvaa42s9KzXInh+pGfZUy1EE3b// b8HfMSreqKsNXVOitiU27sZs0lbhK887EyEMe5RGj629tKQTDVhhwRaz1pk4O4GfM6zbiDB +mNpuyFDE5DtfO6kAe4ug== X-UI-Out-Filterresults: notjunk:1;V01:K0:49irdCWI+2Y=:6L9X1y9nJLe8QLHu1mE7uN qJTw56OfqS+1mOBJAu40u5IaPXB832kuoqwgKB8aL8xkB9s7jcKKwZ0yXW1RKl57kTc5JlC8l qvnb2+ikpadIvxJcFknFHiGChbXiA4RIt3dJdRQYCN0MQtKIzK4tUQBKOXbmGkmPPTfGn52r2 GVLVmsDLf+NKTxHqjqPLHdpMOjCWT7n+h5ZpCqXwpJYyzzP0kYPSzhovD/q4aV+fuW6n+R32E pe5EHCFpsdKmEOS4dVndfLMvsZtZJBj0QqOlcbyKyQTOtsPQiEiKy1AZU/LhzQAwZYBoHFw6y ZRai8fyo7eVMTnSKg/if7EawzvEb6YxrqWigrWR0EhlinmisZq8b62mBdqe7K1+WYWHXDhf+T Y0CexPk4HBNEUzwzfjS+wYpEf7I9m6BDxGbzuOMbfHvDrNIMFNdNUNnWH6GgVm4jfr+7J1Gaj a6hAIZxmUmJ7CfYvZAaLRXLXpYcWNciN0gXlAxuENlfcNu3KPiFgn6NN4f6sFQgoc2fuEkM/H pnnOLHsSfMJWR2/xhgov81ylKN9xcqN2CTfZPC9/kTnN3sBXLGaWcNW9OJQW3GyCw6fBBzycl qo3uZlNUc+IAHpAnfcXlyM0xy80wfonZrYsstxtdLZamePvjqxsGEpWK+7UGspFuWpodDIfRM T1iLRIPCMwAq31+aA5Ct4rG+OEMnV0EgaeI+AUU3p74r8yt2zX+ur1p0SgqlPBTPhhCY= Cc: "cerowrt-devel@lists.bufferbloat.net" Subject: Re: [Cerowrt-devel] performance numbers from WRT1200AC (Re: Latest build test - new sqm-scripts seem to work; "cake overhead 40" didn't) X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2015 08:10:37 -0000 HI Mikael, On Jun 29, 2015, at 09:54 , Mikael Abrahamsson wrote: > On Mon, 29 Jun 2015, Sebastian Moeller wrote: >=20 >> Good work-around; not a real solution as sqm_logger() will also = add "SQM:=94. I think the solution most likely is to remove line 155 = completely. But weirdly this seems to work with cerowrt=85 Correction, calling logger with an empty string works on cero = (as well as on openwrt), but passing an empty string to sqm_logger = results in the observed bug, so I can reproduce this locally. >=20 > May I suggest a wrapper around the logger part that handles this case, = ie if the string is empty? Because when the string is empty and it gets = stuck, luci just waits and waits and waits. I mean, this specific case = can be fixed, but for the future it would be more robust if this error = case can't happen at all. >=20 > --=20 > Mikael Abrahamsson email: swmike@swm.pp.se I had a look at sqm_logger(): sqm_logger() { logger -t SQM -s ${1} } and hope that sqm_logger() { logger -t SQM -s "${1}=94 } Fixes the issue for me and is more concise than trying to introduce real = error handling in sqm_logger. Does this also work for you? Best Regards Sebastian=