From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-x22e.google.com (mail-wi0-x22e.google.com [IPv6:2a00:1450:400c:c05::22e]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 0D3CD21F1C7 for ; Sun, 22 Dec 2013 14:26:41 -0800 (PST) Received: by mail-wi0-f174.google.com with SMTP id z2so10345936wiv.1 for ; Sun, 22 Dec 2013 14:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=26QfUlMCRGbMpgq6TTUC2WhHr1USupWzI2q5Rmi6zIY=; b=o2CCp5Q99TS07KUsH0MeuPBXx6m4h5ZBxoZj/iiFQU27BeaN9ky+xWVIc1xbG1rOfS lZVZpM03oSQrhmeyWdlmYC+AGAI5ad1sBpYCsID1wo1ov2seRX/e3pHjSfUx59jTiHgQ ZBVNxePXVmJiPMIvkX/6B9L6eWDJsylYV8+bKbQDe9ek8NzkjCa8OGK1pB3rv3QWnNpg ueU/+Tc0pP96Fsil7GVpwLYDWO/eFPgSN6TwBcHpN62DTb20/qUjKMviw32q13QoDywF 9vDPcxVLJXR2obfB79hgl7XeZBDw83/0nED7NYkuONkKGH2MTpEJOzZ/cKF0CLtFCuQs K5Dg== X-Received: by 10.194.86.70 with SMTP id n6mr341291wjz.71.1387751199935; Sun, 22 Dec 2013 14:26:39 -0800 (PST) Received: from ?IPv6:2001:470:6aac:3:511d:39de:709b:3a86? ([2001:470:6aac:3:511d:39de:709b:3a86]) by mx.google.com with ESMTPSA id pt8sm8499296wjc.17.2013.12.22.14.26.38 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 22 Dec 2013 14:26:38 -0800 (PST) Message-ID: <52B76719.5070203@gmail.com> Date: Sun, 22 Dec 2013 22:26:33 +0000 From: Robert Bradley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: cerowrt-devel@lists.bufferbloat.net References: In-Reply-To: X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Cerowrt-devel] instruction traps on tcp_rcv - bug 360 regression - reopened X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Dec 2013 22:26:42 -0000 On 22/12/13 21:35, Dave Taht wrote: > http://www.bufferbloat.net/issues/360 > > I would be very reluctant to take seriously any benchmarks going to > the router until this one is quashed. Really bad behavior (I put a > plot up on the bug) > > Stuff going through the router appears to be sane, but if you are monitoring > the router at the same time (like via ssh or a web page) there are > side effects visible at higher rates. > > I am hopefully getting setup to do ipv6 again soon so as to make sure > all those bugs remain squashed too.... > It looks like tcp_parse_aligned_timestamp() in net/ipv4/tcp_input.c has acquired an if(*ptr) statement between 3.8 and 3.10. That bug had been annoying me for a while... diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 3d67689..c6496eb 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -3632,7 +3632,7 @@ static bool tcp_parse_aligned_timestamp(struct tcp_sock *tp, const struct tcphdr ++ptr; tp->rx_opt.rcv_tsval = get_unaligned_be32(ptr); ++ptr; - if (*ptr) + if (net_hdr_word(ptr)) tp->rx_opt.rcv_tsecr = get_unaligned_be32(ptr) - tp->tsoffset; else -- Robert Bradley