From: Robert Bradley <robert.bradley1@gmail.com>
To: cerowrt-devel@lists.bufferbloat.net
Subject: Re: [Cerowrt-devel] Fwd: [bug #442] ath9k queue hang
Date: Wed, 16 Apr 2014 18:25:16 +0100 [thread overview]
Message-ID: <534EBCFC.9000504@gmail.com> (raw)
In-Reply-To: <CAA93jw5ORVLKNwN61jXwgjRYs2rHYzWUZcL8cPiLYFwHqKFvig@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
On 16/04/2014 18:00, Dave Taht wrote:
> should I have said "de-protected"? in
>
> linux-3.14/drivers/net/wireless/ath/ath9k/xmit.c
<snip>
> if (info->flags & IEEE80211_TX_CTL_PS_RESPONSE) {
> ath_txq_unlock(sc, txq);
> txq = sc->tx.uapsdq;
> ^^^^^^
> ath_txq_lock(sc, txq);
> } else if (txctl->an &&
>
Isn't the point here that you're potentially switching txq and so need
to unlock the old one and then lock the new one?
--
Robert Bradley
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
next prev parent reply other threads:[~2014-04-16 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 19:00 Dave Taht
2014-04-16 13:11 ` Felix Fietkau
2014-04-16 15:34 ` Dave Taht
2014-04-16 16:55 ` Felix Fietkau
2014-04-16 17:00 ` Dave Taht
2014-04-16 17:25 ` Robert Bradley [this message]
2014-04-16 17:38 ` Dave Taht
2014-04-16 21:05 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534EBCFC.9000504@gmail.com \
--to=robert.bradley1@gmail.com \
--cc=cerowrt-devel@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox