From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-x22a.google.com (mail-wg0-x22a.google.com [IPv6:2a00:1450:400c:c00::22a]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 9FF5121F204 for ; Wed, 16 Apr 2014 10:25:35 -0700 (PDT) Received: by mail-wg0-f42.google.com with SMTP id y10so11082025wgg.25 for ; Wed, 16 Apr 2014 10:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=njRr0nVKv63EFyhAjNBk0pLQY1T53V4wAfkSBuVhCo4=; b=KAH6jyQSZtFncorEmXh3y4x/RPtQwDMXKcbnq9CU2DFBTr776z0wVKNKXj4WahdCE1 iNGliQy6sDDJ+6zkykFaD/JcpyA2v86H0wEOraSJB95aQIa3r9gwl1NavHG47g9Go9Zo m55zXdY25SYkcr/F8ncL2hHoj/4aO/zlWnqSjGXg+Ndih0VV7RdhxrTWUMuG75zLO+hu oPj/8PCFnAfMNoG2fyeqtOPntxOTUJaRKmuH+ZfMovNZylnoFasWY9IsZeow9cSCSODx bYLrD1t8IH+5Nt37Gqfpm89743TBdA/SHrgHWgvhVci7ARV8Fk44yJteJWwEbE9Lz4MY X0xA== X-Received: by 10.180.10.164 with SMTP id j4mr20380208wib.51.1397669133748; Wed, 16 Apr 2014 10:25:33 -0700 (PDT) Received: from ?IPv6:2001:470:6aac:1:555:55db:3ed4:fa92? ([2001:470:6aac:1:555:55db:3ed4:fa92]) by mx.google.com with ESMTPSA id i9sm37110270wiy.17.2014.04.16.10.25.32 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Apr 2014 10:25:32 -0700 (PDT) Message-ID: <534EBCFC.9000504@gmail.com> Date: Wed, 16 Apr 2014 18:25:16 +0100 From: Robert Bradley User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: cerowrt-devel@lists.bufferbloat.net References: <534E8168.50003@openwrt.org> <534EB61C.1080108@openwrt.org> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NlcqhdPjmQcAt29b4nBlUkFFU74QxSB16" Subject: Re: [Cerowrt-devel] Fwd: [bug #442] ath9k queue hang X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2014 17:25:36 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NlcqhdPjmQcAt29b4nBlUkFFU74QxSB16 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 16/04/2014 18:00, Dave Taht wrote: > should I have said "de-protected"? in > > linux-3.14/drivers/net/wireless/ath/ath9k/xmit.c > if (info->flags & IEEE80211_TX_CTL_PS_RESPONSE) { > ath_txq_unlock(sc, txq); > txq =3D sc->tx.uapsdq; > ^^^^^^ > ath_txq_lock(sc, txq); > } else if (txctl->an && > Isn't the point here that you're potentially switching txq and so need to unlock the old one and then lock the new one? --=20 Robert Bradley --NlcqhdPjmQcAt29b4nBlUkFFU74QxSB16 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTTr0OAAoJEGK/UXZZ8Ak6+GUP/0Id1LVIMFNmLpblmB+TKmE4 Dxbo9q4mkhsWJLU07uaHPGrwVZEhoPsPcc+wTCwBXF3/AU56PcM/QD3CQVJpN8RF 7iAEFMmiD40ZdIxBnMKSuGVwoW8EMxNghS+r1hvcNksEX2+nhJAC75x360ZxtZGt n5NVgDEVs8Dd2Ri5kpM5Jjc73Qk9TS7v5fcHdmQZ34iVOOo/nYHpy5wCTCRKpwr9 gGhroZXkIs7gyZ2CZ2bFCy1sUlT2d76c6PJD4XYTW541op4S0N1p2TnDQklDgyIW igNmGMmOHu+Wkr+e8DcRxScMK2KKZdfcowV48mO7Q7giB1xLNPEkeHwRX8g53wIF yVX56b1N/IHKf9TE/mPor104BLl8LgWejhM2Onr4p3pyNAvo7BMs5/gOr58xFlxF oYukQAmGFOJznFoXQVCcOOXceSCwRSnlBoASqh3zIJK4AbjKIoEuaJDts7kOADt6 C7w0b/uotocNl+XirBJ4l8bSRvweinTYBRVrKXBx33pBsWVm/7nddWodqulkmkRy twYOJSRpL+lYpedGVcS+yVl0cIZvF7aW2/GQHHZTEeTEhByzAo0cReYAjZqCA4xd CEd8Z2Sz3B1vpb3SmNnOlmcdsgS6MbwopBjzkuP2NqEDrNh255OluDMTjRcH3dKW a1xiWTQt/h8dy8HR4Z3K =HsPp -----END PGP SIGNATURE----- --NlcqhdPjmQcAt29b4nBlUkFFU74QxSB16--