From: Robert Bradley <robert.bradley1@gmail.com>
To: cerowrt-devel@lists.bufferbloat.net
Subject: Re: [Cerowrt-devel] [bug #442] tearing apart ath_tx_start in search of the hang
Date: Wed, 16 Apr 2014 18:28:17 +0100 [thread overview]
Message-ID: <534EBDB1.7040705@gmail.com> (raw)
In-Reply-To: <534CF446.2030809@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On 15/04/2014 09:56, Robert Bradley wrote:
> Not as far as I can tell from the documentation. I did notice though
> that the wakeup code in ath_tx_complete() lacks the
> ath_txq_lock()/ath_txq_unlock() calls around it. I don't know if that
> helps or not...
Slight correction; make that ath_txq_skb_done()
(http://lxr.free-electrons.com/source/drivers/net/wireless/ath/ath9k/xmit.c#L150).
It might not matter though if the queue's stopped at the time.
--
Robert Bradley
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
prev parent reply other threads:[~2014-04-16 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 23:08 Dave Taht
2014-04-15 8:56 ` Robert Bradley
2014-04-16 17:28 ` Robert Bradley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534EBDB1.7040705@gmail.com \
--to=robert.bradley1@gmail.com \
--cc=cerowrt-devel@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox