Re: [Cerowrt-devel] [Bug #442] < vs <= in two comparisons

[Felix Fietkau <nbd@openwrt.org>]

On 2014-04-19 05:26, Dave Taht wrote:
> Could part of it be as simple as not checking for '<='  but only < in
> txq_max_pending below?
I don't see how that would make any meaningful difference in practice.
By the way, did you test my patch?

> in ath_tx_start:
> 
>         ath_txq_lock(sc, txq);
>         if (txq == sc->tx.txq_map[q] &&
>             ++txq->pending_frames > sc->tx.txq_max_pending[q] &&
>             !txq->stopped) {
>                 ieee80211_stop_queue(sc->hw, q);
>                 txq->stopped = true;
>         }
> 
> in ath_txq_skb_done:
> 
>         if (txq->stopped &&
>             txq->pending_frames < sc->tx.txq_max_pending[q]) {
>                 ieee80211_wake_queue(sc->hw, q);
>                 txq->stopped = false;
>         }
> 
>