From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-x235.google.com (mail-we0-x235.google.com [IPv6:2a00:1450:400c:c03::235]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id DEB0C21F36C for ; Sun, 15 Feb 2015 08:33:44 -0800 (PST) Received: by mail-we0-f181.google.com with SMTP id w62so25162914wes.12 for ; Sun, 15 Feb 2015 08:33:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=32CC1IDmBTbl1+GYm95017NGM5l5FetF8p1dvKhvwXM=; b=aLGjM9QKAuKydpwwgjUxAjm7i/82icAW4AkpS4ZJq2fcjUFbRFyQ+nGQDNRagmRfSS JJk/wfYv73qMQDHd50FRu/MREzgO3V/do8dnK/tC/qdLOisQVHzRC/uaTRr+wfmxN6Io bUiRRM9PepLGznhKr51mWLpbSsMItAYsjG3DxDFii56Q6/uGRV1+iVe5RfOZvefvrvke UcrJs8ox5YfDTtlzkdy3wpShVdJ+5I80flxWL/Y6crBbZho/V8U+tYEL+bqnKef1Aq30 L8pu8oXl1ewHyxdHYb2Uf9Hb8QX0059zjgTXzt8tnPzpwhYbQsaopCW0vVomHpk7iJCy /4Sg== X-Received: by 10.180.39.72 with SMTP id n8mr38067935wik.59.1424018022541; Sun, 15 Feb 2015 08:33:42 -0800 (PST) Received: from volcano.scree.dyndns.org (host-89-243-99-233.as13285.net. [89.243.99.233]) by mx.google.com with ESMTPSA id do1sm11755059wib.3.2015.02.15.08.33.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Feb 2015 08:33:41 -0800 (PST) Message-ID: <54E0CA64.7000101@gmail.com> Date: Sun, 15 Feb 2015 16:33:40 +0000 From: Alan Jenkins User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: cerowrt-devel@lists.bufferbloat.net References: <54E0AFB2.5040806@gmail.com> <87vbj3i5hz.fsf@toke.dk> <87r3tri2x3.fsf@toke.dk> In-Reply-To: <87r3tri2x3.fsf@toke.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Cerowrt-devel] [sqm-scripts] not started at boot? X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2015 16:34:13 -0000 On 15/02/15 15:56, Toke Høiland-Jørgensen wrote: > Sebastian Moeller writes: > >> I am not sure that this works as intended. The first thing >> run.sh does is take down all running SQM instances: > Ah yes, seems I was a bit too trigger-happy there ;) I was just about to explain the same, after testing it :). (I have more interfaces coming up after pppoe-wan, so SQM stops immediately after it's started) > Here's a version of run.sh that should also short-circuit the 'down' > part if called from hotplug. Yep. that version works ok. > The alternative is, of course, to have logic in the hotplug script to > only call run.sh for interfaces that are enabled, but that would require > parsing /etc/config/sqm from there. My initial thought was that > short-circuiting the logic in run.sh was 'cleaner'; but I'm not entirely > sure about that... Thoughts? > > -Toke It's a small tweak, but maybe the argument to run.sh could be made explicit. run.sh start $DEVICE # specific device run.sh # all devices Regards Alan