Development issues regarding the cerowrt test router project
 help / color / mirror / Atom feed
From: Pete Heist <pete@heistp.net>
To: Sebastian Moeller <moeller0@gmx.de>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	bloat@lists.bufferbloat.net, "Matt Taggart" <matt@lackof.org>,
	cerowrt-devel <cerowrt-devel@lists.bufferbloat.net>
Subject: Re: [Cerowrt-devel] [Bloat] Ubiquiti Launches a Speed Test Network
Date: Sat, 07 Sep 2019 11:33:51 -0000	[thread overview]
Message-ID: <5D47BF2C-025A-46F0-857C-B2EB673ED798@heistp.net> (raw)
In-Reply-To: <87lfv1xbmk.fsf@toke.dk>


> On Sep 7, 2019, at 1:12 AM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> 
>>>> From irtt help client:
>>>> --fill=fill    fill payload with given data (default none)
>>>>              none: leave payload as all zeroes
>>>>              rand: use random bytes from Go's math.rand
>>>>              pattern:XX: use repeating pattern of hex (default 69727474)
>>>> --fill-one     fill only once and repeat for all packets
>>>> --sfill=fill   request server fill (default not specified)
>>>>              see options for --fill
>>>>              server must support and allow this fill with --allow-fills
>>> 
>>> As above, we're doing --fill=rand today.
>> 
>> 	Sama as above, but maybe Pete could be convinced to do the read back of the first X bytes automatically.
> 
> Certainly not opposed to adding this support to Flent if it materialises
> in irtt :)

Coming into this late so haven’t parsed the full request, but irtt sends the requested DSCP value passed in via --dscp to the server during the handshake. It would be possible, though not very intuitive, to pull this out of the initial request packet, which contains type/value pairs encoded with varint style encoding: https://developers.google.com/protocol-buffers/docs/encoding.

The format of the request is “documented” in code in the bytes() method in params.go. Visually, the DSCP value is often the value 0x08, close to the end of the initial packet, following by the DSCP value as a signed varint. (Clearly, it would have made more sense if I’d just sent that as an unsigned byte instead of using a varint, let alone a signed one, but I just leaned on the binary package’s varint support, such as it is, so one has to grok this: https://developers.google.com/protocol-buffers/docs/encoding#signed-integers. I’ve added it to irtt’s todo list to clean this up before 1.0, which will mean a protocol version bump).

One unfortunate thing is that if the goal is to verify that DSCP values have not been modified along the way (without a pcap), afaik the receiver has no way of obtaining the received DSCP value in user space without opening up a raw socket and parsing the IP packet in full (requiring root). But, figuring it out from packet dumps would be possible. If I ever get around to adding irtt support to scetrace (https://github.com/heistp/scetrace), I could detect and count changes to dscp values there, though that’s a ways off at the moment.

Knowing all this, are there any simple changes I can make to get you what you need?


  reply	other threads:[~2019-09-07 11:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 19:51 [Cerowrt-devel] " Matt Taggart
2019-09-06  8:15 ` Mikael Abrahamsson
2019-09-06  8:27   ` [Cerowrt-devel] [Bloat] " Toke Høiland-Jørgensen
2019-09-06  9:56     ` Sebastian Moeller
2019-09-06 12:18       ` Mikael Abrahamsson
2019-09-06 17:59       ` Toke Høiland-Jørgensen
2019-09-06 18:33         ` Sebastian Moeller
2019-09-06 22:50           ` Toke Høiland-Jørgensen
2019-09-06 22:56             ` Sebastian Moeller
2019-09-06 23:12               ` Toke Høiland-Jørgensen
2019-09-07 11:33                 ` Pete Heist [this message]
2019-09-07 12:02                   ` Sebastian Moeller
2019-09-07 13:09                     ` Pete Heist
2019-09-07 13:47                     ` Valdis Klētnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5D47BF2C-025A-46F0-857C-B2EB673ED798@heistp.net \
    --to=pete@heistp.net \
    --cc=bloat@lists.bufferbloat.net \
    --cc=cerowrt-devel@lists.bufferbloat.net \
    --cc=matt@lackof.org \
    --cc=moeller0@gmx.de \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox