From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: Dave Taht <dave.taht@gmail.com>,
make-wifi-fast@lists.bufferbloat.net,
"cerowrt-devel\@lists.bufferbloat.net"
<cerowrt-devel@lists.bufferbloat.net>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: [Cerowrt-devel] [Make-wifi-fast] wifi airtime fairness patches could use eyeballs and testing
Date: Thu, 11 Aug 2016 00:45:28 +0200 [thread overview]
Message-ID: <8737mc9rav.fsf@toke.dk> (raw)
In-Reply-To: <736D102C-3383-457B-96C4-D1B1403F48AE@gmail.com> (Jonathan Morton's message of "Thu, 11 Aug 2016 01:18:18 +0300")
Jonathan Morton <chromatix99@gmail.com> writes:
>> On 11 Aug, 2016, at 01:05, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>
>> There are cwnd reductions, yes, but are they drops? My thought was
>> that they were retransmissions caused by OOO packets?
>
> You should be able to find the retransmitted packets, in that case.
> But FQ shouldn’t be reordering packets within the same flow.
No, but the WiFi retransmission logic might. Specifically, the ath9k
will put packets in a retry buffer that takes precedence over new
packets when building aggregates. But since it has one or two aggregates
built already by the time it does this, reordering can occur that way.
Now, digging in to the packet traces (looking at the single flow case,
since that is easier to follow), there's a ~320k segment of the sequence
space that is about 1.5MB and 200 ms late (sequence numbers 10044929
through 10370177 show up after sequence number 11617665 at around the
12k packet mark in the trace). This is nine full aggregates being
reordered.
I'm not really sure the reordering mechanism described above can account
for this, unless there are some pretty serious hardware buffering going
on that we are not aware of. Does anyone else have any ideas?
-Toke
next prev parent reply other threads:[~2016-08-10 22:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 11:28 [Cerowrt-devel] " Dave Taht
2016-08-10 13:06 ` [Cerowrt-devel] [Make-wifi-fast] " Noah Causin
2016-08-10 13:11 ` Dave Taht
2016-08-10 15:04 ` Toke Høiland-Jørgensen
2016-08-10 19:35 ` Dave Taht
2016-08-10 20:06 ` Toke Høiland-Jørgensen
2016-08-10 21:50 ` Toke Høiland-Jørgensen
2016-08-10 21:58 ` Dave Taht
2016-08-10 22:05 ` Toke Høiland-Jørgensen
2016-08-10 22:07 ` Toke Høiland-Jørgensen
2016-08-10 22:18 ` Jonathan Morton
2016-08-10 22:45 ` Toke Høiland-Jørgensen [this message]
2016-08-11 6:43 ` Dave Taht
2016-08-11 9:16 ` Toke Høiland-Jørgensen
2016-08-14 22:21 ` Dave Taht
2016-08-14 22:49 ` Aaron Wood
2016-08-14 23:02 ` Dave Taht
2016-08-14 23:04 ` Aaron Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737mc9rav.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cerowrt-devel@lists.bufferbloat.net \
--cc=chromatix99@gmail.com \
--cc=dave.taht@gmail.com \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox