From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by huchra.bufferbloat.net (Postfix) with ESMTPS id 1281E21F24B for ; Sun, 15 Feb 2015 08:18:42 -0800 (PST) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk Received: by alrua-karlstad.karlstad.toke.dk (Postfix, from userid 1000) id 5C3AE28DC43; Sun, 15 Feb 2015 17:18:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toke.dk; s=201310; t=1424017115; bh=+j19/qXLhqgF+pLzUDo2STKuBnOJubLCnb6iVujGV8U=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=bBY2P/8znqjezv49XN4GzoeBNBzl8JYKoLLwoGpI7CsYYwya465pc2hSz0a8JDmXW HaZZLLUnquLB4WJ6Htn6bgoUWeGtgaLiI+GWEwbS2w96Ew03xPu9Xl3NYIq9PWubgL YrcLBZ8/VGfO3QkAaEoVgPh0bmwMZsp5V81Db5a8= From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Sebastian Moeller References: <54E0AFB2.5040806@gmail.com> <87vbj3i5hz.fsf@toke.dk> <87r3tri2x3.fsf@toke.dk> <9EB28655-6E25-470B-A13B-036EE00D84D7@gmx.de> Date: Sun, 15 Feb 2015 17:18:34 +0100 In-Reply-To: <9EB28655-6E25-470B-A13B-036EE00D84D7@gmx.de> (Sebastian Moeller's message of "Sun, 15 Feb 2015 17:12:41 +0100") Message-ID: <87lhjz1739.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Alan Jenkins , openwrt-devel@lists.openwrt.org, luis@bitamins.net, cerowrt-devel@lists.bufferbloat.net Subject: Re: [Cerowrt-devel] [sqm-scripts] not started at boot? X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2015 16:19:11 -0000 Sebastian Moeller writes: > Not that I have shown great taste in the past, but I think it > would be somewhat cleaner to put the logic into the hot plug script > and keep run.sh =E2=80=9Csimple=E2=80=9D (in the past I had introduced a = large number > of leakage, especially of IFBs by not properly removing/stopping old > instances and was quite happy to have the take all active interfaces > down loop as a last defense against accidental leaks). Well, the biggest issue I can see with not having any logic in run.sh is that in that case, *all* interfaces will be reconfigured when the hotplug event happens. However, I'm not sure exactly how common it is to have more than one interface configured for SQM, and if so, whether or not reconfiguring everything on every hotplug event (well, only for for SQM-enabled interfaces I suppose) is an issue. The modifications to run.sh should keep it functioning the way it does currently if run 'manually' the shell or LUCI. Unless the $DEVICE env-var is set for some other reason... > But I am now also running pppoe directly from cerowrt and see > the same issue, sqm is confused when the pppoe interface > temporarily goes away, so at least I can now test this issue ;) Well, a first pass could be to see if the modified run.sh I sent last time around actually works... ;) -Toke