From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 6398421F2C5 for ; Mon, 16 Feb 2015 01:05:15 -0800 (PST) Received: from hms-beagle.lan ([134.2.89.70]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MT74k-1XyZTC3Yf8-00S7Kx; Mon, 16 Feb 2015 10:05:12 +0100 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Moeller In-Reply-To: <54E0CA64.7000101@gmail.com> Date: Mon, 16 Feb 2015 10:05:11 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <54E0AFB2.5040806@gmail.com> <87vbj3i5hz.fsf@toke.dk> <87r3tri2x3.fsf@toke.dk> <54E0CA64.7000101@gmail.com> To: Alan Jenkins , =?windows-1252?Q?Toke_H=F8iland-J=F8rgensen?= X-Mailer: Apple Mail (2.1878.6) X-Provags-ID: V03:K0:aAZIbfl/mqXMfOjHNPZCrmgiZbkcqBSs3Lj8yTa1ra03eh2jwid sMmRtvk75f1vQ67+KCSHPS0HiOb2vUZffJHEHbkur+y6lsjASEUUBX1kAYeX6WE+Sc0d6Kc Uhz2QijqM+bOdDEfnqjAad4RyKnirpy29SZnXmUQLz9ACwPkYJcL4DF0K28voFDNMfTBpEV umKsozy7s1E2qc9RBS6MA== X-UI-Out-Filterresults: notjunk:1; Cc: cerowrt-devel Subject: Re: [Cerowrt-devel] [sqm-scripts] not started at boot? X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 09:05:45 -0000 Hi Alan, hi Toke, On Feb 15, 2015, at 17:33 , Alan Jenkins = wrote: >=20 > On 15/02/15 15:56, Toke H=F8iland-J=F8rgensen wrote: >> Sebastian Moeller writes: >>=20 >>> I am not sure that this works as intended. The first thing >>> run.sh does is take down all running SQM instances: >> Ah yes, seems I was a bit too trigger-happy there ;) > I was just about to explain the same, after testing it :). (I have = more interfaces coming up after pppoe-wan, so SQM stops immediately = after it's started) >=20 >> Here's a version of run.sh that should also short-circuit the 'down' >> part if called from hotplug. > Yep. that version works ok. >=20 >> The alternative is, of course, to have logic in the hotplug script to >> only call run.sh for interfaces that are enabled, but that would = require >> parsing /etc/config/sqm from there. My initial thought was that >> short-circuiting the logic in run.sh was 'cleaner'; but I'm not = entirely >> sure about that... Thoughts? >>=20 >> -Toke >=20 > It's a small tweak, but maybe the argument to run.sh could be made = explicit. >=20 > run.sh start $DEVICE # specific device > run.sh # all devices Mmmh, that sounds like a decent plan, I will see how it looks = after I implemented it. Most likely I will not get around to that before = next weekend though=85 Best Regards Sebastian >=20 > Regards > Alan > _______________________________________________ > Cerowrt-devel mailing list > Cerowrt-devel@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cerowrt-devel