Development issues regarding the cerowrt test router project
 help / color / mirror / Atom feed
* [Cerowrt-devel] can bus attack
@ 2023-04-14  4:04 Dave Taht
  2023-04-14  6:08 ` Sebastian Moeller
  0 siblings, 1 reply; 3+ messages in thread
From: Dave Taht @ 2023-04-14  4:04 UTC (permalink / raw)
  To: cerowrt-devel, bloat

The biggest bug with the early fq_codel deployment was that it dropped
from head and fq'd which led to the prospect of messages sent out of
order on the can protocol, which was not designed for that.. After
much thought, we ended up overriding the default fq_codel qdisc, for a
fifo, for the can bus devices, but there were a few years there where
fq_codel was the default for can, in openwrt, which sometimes keeps me
awake at night.

This set of security bugs is bigger and essentially a message flood
attack on a FIFO, making it possible to steal a car via accessing the
headlamp, using a 10 dollar adaptor. Fascinating reading.

https://kentindell.github.io/2023/04/03/can-injection/


--
AMA March 31: https://www.broadband.io/c/broadband-grant-events/dave-taht
Dave Täht CEO, TekLibre, LLC

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Cerowrt-devel] can bus attack
  2023-04-14  4:04 [Cerowrt-devel] can bus attack Dave Taht
@ 2023-04-14  6:08 ` Sebastian Moeller
  2023-04-14  6:25   ` Bill Woodcock
  0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Moeller @ 2023-04-14  6:08 UTC (permalink / raw)
  To: Dave Täht; +Cc: cerowrt-devel, bloat

Hi Dave,


> On Apr 14, 2023, at 06:04, Dave Taht via Cerowrt-devel <cerowrt-devel@lists.bufferbloat.net> wrote:
> 
> The biggest bug with the early fq_codel deployment was that it dropped
> from head and fq'd which led to the prospect of messages sent out of
> order on the can protocol, which was not designed for that..

	[SM] How did CAN react to this bug? Fixing its design or simply requiring in-order-delivery?

> After
> much thought, we ended up overriding the default fq_codel qdisc, for a
> fifo, for the can bus devices, but there were a few years there where
> fq_codel was the default for can, in openwrt, which sometimes keeps me
> awake at night.

	[SM] How many critical CAN bus implementations actually use OpenWrt? I thought CAN is big in automobiles, so if any of those use OpenWrt that would be interesting news ;)


> This set of security bugs is bigger and essentially a message flood
> attack on a FIFO, making it possible to steal a car via accessing the
> headlamp, using a 10 dollar adaptor. Fascinating reading.
> 
> https://kentindell.github.io/2023/04/03/can-injection/

	[SM] It appears automobile designers assumed a non-adversarial environment, which is odd given that 3rd party diagnostic dongles that interface with the car network/bus have been a thing for years.
	I guess the good thing is that we do have some well-tested techniques to harden such a design (that are unlikely to be retro-fitable into existing cars, assuming that vendors actually still care about older models anyway).

Regards
	Sebastian


> 
> 
> --
> AMA March 31: https://www.broadband.io/c/broadband-grant-events/dave-taht
> Dave Täht CEO, TekLibre, LLC
> _______________________________________________
> Cerowrt-devel mailing list
> Cerowrt-devel@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cerowrt-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Cerowrt-devel] can bus attack
  2023-04-14  6:08 ` Sebastian Moeller
@ 2023-04-14  6:25   ` Bill Woodcock
  0 siblings, 0 replies; 3+ messages in thread
From: Bill Woodcock @ 2023-04-14  6:25 UTC (permalink / raw)
  To: Sebastian Moeller; +Cc: Dave Täht, cerowrt-devel, bloat

> On Apr 14, 2023, at 8:08 AM, Sebastian Moeller via Cerowrt-devel <cerowrt-devel@lists.bufferbloat.net> wrote:
>> there were a few years there where
>> fq_codel was the default for can, in openwrt, which sometimes keeps me
>> awake at night.
> 
> [SM] How many critical CAN bus implementations actually use OpenWrt? I thought CAN is big in automobiles, so if any of those use OpenWrt that would be interesting news ;)

It’s also widely used in factory-floor and assembly-line automation.

                                -Bill

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-14  6:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-14  4:04 [Cerowrt-devel] can bus attack Dave Taht
2023-04-14  6:08 ` Sebastian Moeller
2023-04-14  6:25   ` Bill Woodcock

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox