From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [IPv6:2a00:1450:400c:c00::22c]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 70CE021F208 for ; Wed, 16 Apr 2014 10:38:36 -0700 (PDT) Received: by mail-wg0-f44.google.com with SMTP id m15so11122087wgh.3 for ; Wed, 16 Apr 2014 10:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=Q/9ykSJRV/IRoFNbmgNlv9Brwqcl4z50KEWz+6K9C5g=; b=EMbDTBTpEAeL/nVUEbSqF/OLTyeDLuPkl8VBiXJePRc/1txkloDZLFqNr1feMJIH3o 8I97PvdgzVEr2o7ojnKgQEhXswH2Ixv9m4gX7UnLmS5f097+5LiEs1kB537B7mWRvBN9 kscCqMTNhhe5CfPXRLJZ4vym+cHGCDSQOBipinkAqZS6zd41wGZuoZ7SJ4Nl0dkW/yF+ ujN1c8xxCRfFRdsBaE9i51lbtGTzNmqiGimCeqcH8nB1bHXG/hnlIC3VNyFngPV6v+Lb pahi9DFzI8ZJ+gNb8PXRYlciznn0IsRZ6Vw4qJsCS1J2OHujQmAdFdGJRR95mAWMG6Gi 9iGw== MIME-Version: 1.0 X-Received: by 10.180.19.167 with SMTP id g7mr8624333wie.46.1397669914436; Wed, 16 Apr 2014 10:38:34 -0700 (PDT) Received: by 10.216.177.10 with HTTP; Wed, 16 Apr 2014 10:38:34 -0700 (PDT) In-Reply-To: <534EBCFC.9000504@gmail.com> References: <534E8168.50003@openwrt.org> <534EB61C.1080108@openwrt.org> <534EBCFC.9000504@gmail.com> Date: Wed, 16 Apr 2014 10:38:34 -0700 Message-ID: From: Dave Taht To: Robert Bradley , Felix Fietkau Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "cerowrt-devel@lists.bufferbloat.net" Subject: Re: [Cerowrt-devel] Fwd: [bug #442] ath9k queue hang X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2014 17:38:36 -0000 On Wed, Apr 16, 2014 at 10:25 AM, Robert Bradley wrote: > On 16/04/2014 18:00, Dave Taht wrote: >> should I have said "de-protected"? in >> >> linux-3.14/drivers/net/wireless/ath/ath9k/xmit.c > >> if (info->flags & IEEE80211_TX_CTL_PS_RESPONSE) { >> ath_txq_unlock(sc, txq); >> txq =3D sc->tx.uapsdq; >> ^^^^^^ >> ath_txq_lock(sc, txq); >> } else if (txctl->an && >> > > Isn't the point here that you're potentially switching txq and so need > to unlock the old one and then lock the new one? But it's happening after incrementing the old one and potentially stopping = it... My take on this bit of code is that it needs to happen before the increment and potental stop, and it should validate the value of tx.uapsdq. but I am by no means the expert here! Felix is da man.... > > -- > Robert Bradley > > > > _______________________________________________ > Cerowrt-devel mailing list > Cerowrt-devel@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cerowrt-devel > --=20 Dave T=C3=A4ht NSFW: https://w2.eff.org/Censorship/Internet_censorship_bills/russell_0296_= indecent.article