From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3AFAE3B29E for ; Tue, 11 Dec 2018 13:39:00 -0500 (EST) Received: by mail-qt1-x842.google.com with SMTP id r14so17638505qtp.1 for ; Tue, 11 Dec 2018 10:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XB7hLIp2PaGmVo9IoySJcbKObmpjd5FFt15N6JEIoHU=; b=klbKTxqznwpId2LtE6dwAX2yr6al7+mmzE0PUDbvzXiaLVOa/W32OgMeB5GSjMCUKL nMs4Ppq28Am2a12uZNuVWaj/MCX1IBUR2dtGSUfr1/L2GreFhfcCt5+8xBeQHWGk2pad n/J8D3aFBk0FFFMMQySUmdSyctyH4pWcrru3+mSK1QOhyD1fyg/yHQi5NGO7Ums0epbW XyUhFlX1O6IWL0sgHBzwL5GTFg5O6J7se/xtlJoKigLVRbZg/CzzT3LAxAROlve8/1zQ tVniC5old3zVlEO80anBPatGEkrrYhtUQc84AIOLwzPm/JXcVhMVRkWhzDpT1BEWvSCU Sm1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XB7hLIp2PaGmVo9IoySJcbKObmpjd5FFt15N6JEIoHU=; b=C0ZsX5VB8QSSd4Ga8/sQ1qgDacm61YlkV3VqpdlLn8uGIWvCUv4+kpLeA28Py708XM hSWMV+DLooGZEWHpPpd7PoT1NHn50ICSHjPmxlfEqw5KrXCAmPvtzjqwMXVMWaMeEgP2 lIaI9a2sny85y7wOGHX8Ygm4a6IbjSKz2CP0PjIbQwcnhwqSZfAqf3VLMsorljTX53Ro spDcp5iuCHZreLQgzn14EZC6UpAtHNg8590fZ9N6jY7wd7tYEGi4ybAxWl9vjfaH8ggg wvq4xE2jTwD2MyuS7bvc/SyRFyAG62oskwsm0hvqYXbPW/4ItOzZjDH2QES819ic1RFW SiGg== X-Gm-Message-State: AA+aEWYf670JzGxduVRZ/NXHenZ0tDs+p/JXS6jPAsik9/sxYjK6t9s3 NulMmxTAYYhtiXwxHTm+34K8hSYAL+4f46fVcjA= X-Google-Smtp-Source: AFSGD/XI4JGNIvSDHl8TXzum+hxWsdmlouzVlB6FAMdN3K/n6Uhd2qKbM57WEGh8/iGXgtxrcHCXpGv/hgbNHDdczks= X-Received: by 2002:a0c:a402:: with SMTP id w2mr16853031qvw.129.1544553539739; Tue, 11 Dec 2018 10:38:59 -0800 (PST) MIME-Version: 1.0 References: <87bm5zgkkg.fsf@toke.dk> In-Reply-To: From: Dave Taht Date: Tue, 11 Dec 2018 10:38:48 -0800 Message-ID: To: Aaron Wood Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , cerowrt-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cerowrt-devel] fq_pie for linux X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 18:39:00 -0000 On Tue, Dec 11, 2018 at 10:37 AM Dave Taht wrote: > > On Tue, Dec 11, 2018 at 10:32 AM Aaron Wood wrote: > > > > On Wed, Dec 5, 2018 at 11:51 PM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> > >> Dave Taht writes: > >> > >> > https://github.com/gautamramk/FQ-PIE-for-Linux-Kernel/issues/2 > >> > >> With all the variants of fq+AQM, maybe decoupling the FQ part and the > >> AQM part would be worthwhile, instead of reimplementing it for each > >> variant... > > > > > > That's a great idea, Toke. There are a lot of places where I think it = could work well, especially if it took a pluggable hash function for the ha= shing (at which point it's very general-purpose, and works on all sorts of = different kinds of packets and workloads). That would let it be used for u= serspace VPN links (as an example), or within QUIC (or similar), where the = kernel can't see the embedded flows that are hidden by the TLS encryption. I really would like us to have reference userspace versions. Also, in userspace, sse based hashing as in spookyhash or city hash might be faster than jenkins. > > > > And having it pluggable in the kernel would also allow IPSec to work wi= thout bloat (last I checked it was horribly bufferbloated, but that was ~5 = years ago). > > ipsec terminating on the router was made to work beautifully with > fq_codel with this commit, below. > > Before: > > http://www.taht.net/~d/ipsec_fq_codel/oldqos.png > > After: > > http://www.taht.net/~d/ipsec_fq_codel/newqos.png > > It's why we keep hoping to do the same thing to wireguard. > > commit 264b87fa617e758966108db48db220571ff3d60e > Author: Andrew Collins > Date: Wed Jan 18 14:04:28 2017 -0700 > > fq_codel: Avoid regenerating skb flow hash unless necessary > > The fq_codel qdisc currently always regenerates the skb flow hash. > This wastes some cycles and prevents flow seperation in cases where > the traffic has been encrypted and can no longer be understood by the > flow dissector. > > Change it to use the prexisting flow hash if one exists, and only > regenerate if necessary. > > > > > -- > > Dave T=C3=A4ht > CTO, TekLibre, LLC > http://www.teklibre.com > Tel: 1-831-205-9740 --=20 Dave T=C3=A4ht CTO, TekLibre, LLC http://www.teklibre.com Tel: 1-831-205-9740