From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-x232.google.com (mail-ob0-x232.google.com [IPv6:2607:f8b0:4003:c01::232]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 1621221F2B8 for ; Sun, 15 Feb 2015 23:58:07 -0800 (PST) Received: by mail-ob0-f178.google.com with SMTP id uz6so39590317obc.9 for ; Sun, 15 Feb 2015 23:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=2MDGssoKragrNEQa5/bcRYtUHRiVL6kwH3XCdA3JVv8=; b=y382I2wxfTfpZG7+qxzCfXuTv3f8r1vKmVCyNHnpRIy0AnnrKggEmE70+KYmoksha/ +Y8jvHL+UqjIxYngRzHWpOiaXTvNnXk92WI9g5dByhdiAEeUxrH8UEjQW9M3KMfwp5gU f0GOyycbv1ebPP9mQ7uH1rvX3+35gPYUfb+2bvGC74QBLXnnF6UHvnhUbAu0V74OzOnC i6amUIaZuaKlEXDpQnUligo2PPCoJP0cp23/VO1W+8HAARyfTSCLWK8FK2SJfmVN+hqm D+qd+V6N+UBhHGRN4umF/fgaNWailOwMyMlft18d/h7BGJAtrWGyNO2n+z+luwODgkWX AGCg== MIME-Version: 1.0 X-Received: by 10.60.145.212 with SMTP id sw20mr14468123oeb.39.1424073486674; Sun, 15 Feb 2015 23:58:06 -0800 (PST) Received: by 10.202.51.66 with HTTP; Sun, 15 Feb 2015 23:58:06 -0800 (PST) Date: Sun, 15 Feb 2015 23:58:06 -0800 Message-ID: From: Dave Taht To: "cerowrt-devel@lists.bufferbloat.net" , John Crispin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Cerowrt-devel] openwrt moves to Linux 3.18 for the ar71xx (wndr3800, ubnt, etc) X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 07:58:36 -0000 see https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg29493.h= tml for details. This starts making doing a version bump of cerowrt a bit more worthwhile, and will make doing make-wifi-fast a bit less painful backport from mainline. However as with any major (2 years!) kernel update there will undoubtably be bugs, and in particular, I would suspect the unaligned_hacks code to need more testing and hacks to handle some new cases. Those of you building openwrt might want to take a look at this. It looked like adding xmit_more support will be straightforward, also, though I don't know if it will be of any benefit. Untested patch: diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/= ag71x index 5ef324e..24607a4 100644 --- a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_= main. +++ b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_= main. @@ -786,8 +786,10 @@ static netdev_tx_t ag71xx_hard_start_xmit(struct sk_bu= ff *s DBG("%s: packet injected into TX queue\n", ag->dev->name); - /* enable TX engine */ - ag71xx_wr(ag, AG71XX_REG_TX_CTRL, TX_CTRL_TXE); + /* enable TX engine if no more data pending */ + if(!skb->xmit_more || + netif_xmit_stopped(netdev_get_tx_queue(ag, 0))) + ag71xx_wr(ag, AG71XX_REG_TX_CTRL, TX_CTRL_TXE); return NETDEV_TX_OK; If it isn't obvious, I'm not planning on doing any builds for a couple days or more, myself, but a big thanks to john crispin for the version bump! Moving further forward... About the most promising thing in the current (3.20/4.0) kernel that could maybe use a backport to 3.18 is the vastly sped up fib_trie code: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit= /?id=3De495f78d787b56ad249946b191406f4521b58150 Very good talk about how difficult it is to do routing lookups and other stuff at 10GigE here, which the above work documents (and applies to our teeny little home router world to some extent) https://plus.google.com/u/0/103747673045238156202/posts/cxbCbqaNHkN There were also a metric ton of good tcp changes (stretch ack handling, improvements to sch_fq) in the current linux head, but those are not really relevant to routing. --=20 Dave T=C3=A4ht http://www.bufferbloat.net/projects/bloat/wiki/Upcoming_Talks