[Cerowrt-devel] Fwd: [PATCH net] pktgen: Fix the inaccurate bps calculation

[Cerowrt-devel] Fwd: [PATCH net] pktgen: Fix the inaccurate bps calculation

[Dave Taht]

heh. Fastest way to change the observed speed of the internet I've yet seen.

---------- Forwarded message ---------
From: <gfree.wind@outlook.com>
Date: Fri, Jul 8, 2022 at 8:51 AM
Subject: [PATCH net] pktgen: Fix the inaccurate bps calculation
To: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>
Cc: <gfree.wind@outlook.com>, Gao Feng <gfree.wind@gmail.com>


From: Gao Feng <gfree.wind@gmail.com>

The prior codes use 1000000 as divisor to convert to the Mbps. But it isn't
accurate, because the NIC uses 1024*1024 from bps to Mbps. The result of
the codes is 1.05 times as the real value, even it may cause the result is
more than the nic's physical rate.

Signed-off-by: Gao Feng <gfree.wind@gmail.com>
---
 net/core/pktgen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 84b62cd7bc57..e5cd3da63035 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3305,7 +3305,7 @@ static void show_results(struct pktgen_dev
*pkt_dev, int nr_frags)
        }

        mbps = bps;
-       do_div(mbps, 1000000);
+       do_div(mbps, 1024 * 1024);
        p += sprintf(p, "  %llupps %lluMb/sec (%llubps) errors: %llu",
                     (unsigned long long)pps,
                     (unsigned long long)mbps,
--
2.20.1



-- 
FQ World Domination pending: https://blog.cerowrt.org/post/state_of_fq_codel/
Dave Täht CEO, TekLibre, LLC