From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-x229.google.com (mail-we0-x229.google.com [IPv6:2a00:1450:400c:c03::229]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 4529B21F19D for ; Sun, 15 Dec 2013 21:13:55 -0800 (PST) Received: by mail-we0-f169.google.com with SMTP id w61so4139573wes.14 for ; Sun, 15 Dec 2013 21:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=Tzz6Wq2DYtzeWpMafTs+VQin6Z66Zt3QvvoLpEGm7mM=; b=DSMaEDXvVUE9EuFfF9G0LBtCWWEuLpv//eFzdZSdsiuXIV4qLdhaj6QFnc+9YSdXXT jmEWFF/kCdS0AD+RgQQ3zC4xdVueKjPf0LWcOLlOAlcGvzUIuofjvx++hxXGUksy023I MhErMFKsJJPCcG6aO2LCOrv6U8RHMXvraCKgurU84Ogqk9jN0S8Wb/hBA0N5Sa3DTZkP 8nlM88CkKKC4PZX04ghUkx+2WF1D6VY77sWMQ7z1n2SXm07R0kp4BhN9wV0QKIbjERrz qI6KgeGDTUhGAjKzodYuvvslb+ISWihnddgkx99PI6YZHHlIQqwFyBo9/ClFkb0Lkc/+ 1ROg== MIME-Version: 1.0 X-Received: by 10.195.13.45 with SMTP id ev13mr11941766wjd.20.1387170833071; Sun, 15 Dec 2013 21:13:53 -0800 (PST) Received: by 10.217.123.69 with HTTP; Sun, 15 Dec 2013 21:13:53 -0800 (PST) In-Reply-To: <227F0904-6A5D-4A83-9DBD-252E3110459B@gmx.de> References: <227F0904-6A5D-4A83-9DBD-252E3110459B@gmx.de> Date: Sun, 15 Dec 2013 21:13:53 -0800 Message-ID: From: Dave Taht To: Sebastian Moeller Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "cerowrt-devel@lists.bufferbloat.net" , Jesper Dangaard Brouer Subject: Re: [Cerowrt-devel] aqm gui feedback on cerowrt-3.10.24-1 for linklayer adaption X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2013 05:13:55 -0000 On Sun, Dec 15, 2013 at 6:28 PM, Sebastian Moeller wrote: > Hi Dave, > > On Dec 14, 2013, at 07:26 , Dave Taht wrote: > >> one of the things that makes me happy with all-up testing is that >> occasionally after completely blowing up my own work, I get to >> critique fresh work that isn't mine, in an area with which I have no >> expertise, with gratitude that I don't have to figure out the answer. >> :) >> >> So I spent some time clicking wildly all over the AQM gui webpage to >> see what I could break. >> >> 1) the aqm gui code doesn't work due to a bug at line 66. >> sc:depends("advanced", "1"). >> sc has to be initialized first, which happens later in the file. Extra >> line removed in ceropackages, committed, pushed, you will need to do a >> pull. Merge failure? >> >> 2) it's not clear to me we have to support both the stab and >> htb_private methods of fixing htb's linklayer. It was important that >> these be fixed for everyone else that uses htb, >> but is one of these is faster than the other? I seem to recall one was >> a calculated value in the kernel, the other some sort of table. Does >> this choice need to be made by the >> user? The two variants benchmarked? Jesper? >> >> 3) Clicking "advanced configuration" on and off toggles display of the >> qdisc and qdisc script, and twiddling with the linklayer value brings >> up all the extra DSL detail. Yea! >> >> ... and I think I was wrong in mentally visualizing the thing >> >> If these were made tabs [Basic, Queueing Discipline, Linklayer, >> Priorities], there would be more room for explanatory text in >> particular and better alignment with the >> "look and feel" of the rest of the gui. Note that "priorities" is a >> placeholder for somehow >> bringing out something remotely similar to what openwrt's qos system >> already does >> and what AQM (ceroshaper? some other name is needed) does implicitly >> with optimizing for dns and ntp. >> >> ECN enablement should be brought out in "Queueing discipline" via the >> ALLECN variable. It seems likely ALLECN needs to have 4 states rather >> than 3, which needs to also be fixed in the scripts. > > Done, that is all 4 states for inbound and outbound ECN can be co= nfigured via the GUI now. > >> >> While I'm at it, perhaps having tabs for each physical interface is >> not a horrible idea, >> but I shudder to think of people rate-limiting their wifi in the hope >> that that would help. >> >> ? >> >> 5) Adding a second interface shows @ge01 as an option, which isn't a >> real interface, and se00 as an option and not the gw* or sw* >> interfaces. Adding se00 with the default option >> gives me an error >> >> One or more required fields have no value! >> One or more required fields have no value! >> One or more required fields have no value! >> One or more required fields have no value! >> >> (and I'm pretty sure the aqm-scripts break even if this is correctly >> written to the config file) >> >> 6) feel free to add your copyright to the code. :) >> >> I return now to figuring out why bringing up the wifi is so hosed. I >> will probably be reverting the kernel, netifd, and other things, way, >> way, way back to when they used to work. >> >> -- >> Dave T=E4ht >> >> Fixing bufferbloat with cerowrt: http://www.teklibre.com/cerowrt/subscri= be.html >> _______________________________________________ >> Cerowrt-devel mailing list >> Cerowrt-devel@lists.bufferbloat.net >> https://lists.bufferbloat.net/listinfo/cerowrt-devel > This patch didn't quite make 3.10.24-4. But nice work all the same. I'll get it next time. --=20 Dave T=E4ht Fixing bufferbloat with cerowrt: http://www.teklibre.com/cerowrt/subscribe.= html