From: Dave Taht <dave.taht@gmail.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: cerowrt@lists.bufferbloat.net,
"cerowrt-devel@lists.bufferbloat.net"
<cerowrt-devel@lists.bufferbloat.net>
Subject: Re: [Cerowrt-devel] Fwd: [bug #442] ath9k queue hang
Date: Wed, 16 Apr 2014 08:34:16 -0700 [thread overview]
Message-ID: <CAA93jw4tWcczq1u3kjfd-i2sH5zDxh-v2MRNfB=dJxbJfdnaJQ@mail.gmail.com> (raw)
In-Reply-To: <534E8168.50003@openwrt.org>
On Wed, Apr 16, 2014 at 6:11 AM, Felix Fietkau <nbd@openwrt.org> wrote:
> On 2014-04-15 21:00, Dave Taht wrote:
>> Thx felix!
>>
>> Given that there seems to be a potential race in the code
>> review I did at:
>>
>> http://www.bufferbloat.net/issues/442#note-22
>>
>> another thought is to make the increment and decrement of
>>
>> txq->pending_frame atomic, or to do a flush before the unlock
> I'm not convinced that there's a race that involves txq->pending_frames.
> There is no need to make the increment/decrement atomic, because that
> variable is already protected by the txq lock.
It and "stopped" are briefly unprotected along that code path.
>
>> What tree is this patch against?
> mac80211 from OpenWrt trunk.
Thx, will try your patch today.
> - Felix
--
Dave Täht
NSFW: https://w2.eff.org/Censorship/Internet_censorship_bills/russell_0296_indecent.article
next prev parent reply other threads:[~2014-04-16 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 19:00 Dave Taht
2014-04-16 13:11 ` Felix Fietkau
2014-04-16 15:34 ` Dave Taht [this message]
2014-04-16 16:55 ` Felix Fietkau
2014-04-16 17:00 ` Dave Taht
2014-04-16 17:25 ` Robert Bradley
2014-04-16 17:38 ` Dave Taht
2014-04-16 21:05 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA93jw4tWcczq1u3kjfd-i2sH5zDxh-v2MRNfB=dJxbJfdnaJQ@mail.gmail.com' \
--to=dave.taht@gmail.com \
--cc=cerowrt-devel@lists.bufferbloat.net \
--cc=cerowrt@lists.bufferbloat.net \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox