From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-x231.google.com (mail-we0-x231.google.com [IPv6:2a00:1450:400c:c03::231]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 9BF4B21F100 for ; Mon, 14 Apr 2014 12:57:44 -0700 (PDT) Received: by mail-we0-f177.google.com with SMTP id u57so8470455wes.22 for ; Mon, 14 Apr 2014 12:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=lTNSQDauw4v94qb4rdKchkWCyxFYuI+HMI4c2DavKoQ=; b=K4Qqf5XYnwezvkomVxb6zU/lUle7PbQnsRH5X0ijpjvUOj52lBeeHRCDwgAOvhf9so pjqGaKJdyM6eVw4xKCk2pPqScNLhYipDjilMAE9meNeA5IrH+LZtHLM9HnaU6GPvJn34 ZJVKf3tAzvONYq3QQNJDsy2ahtF/ccNxbqc3OlBKjFWAE6BvYj6hkhT5HeBKdqmEAtOw EyXeNbdZaB8NbEu8nLmA2fp2GxSD9f39cxMtSJ9xBpwqo6pm6ksEd05KAyOC7Io4MOPL tw5cSYbKHHu8j09GEG9yP/Rkdw145G3+9sdkAiYrxyoTSpbTmqYTc5Exmr9Ct8uBK/Gr AkAg== MIME-Version: 1.0 X-Received: by 10.180.76.166 with SMTP id l6mr132169wiw.17.1397505462114; Mon, 14 Apr 2014 12:57:42 -0700 (PDT) Received: by 10.216.177.10 with HTTP; Mon, 14 Apr 2014 12:57:42 -0700 (PDT) In-Reply-To: <534C2A58.8000604@travelguide.gr> References: <5349B456.4060004@travelguide.gr> <5349C94B.7020706@travelguide.gr> <534AD864.6030803@travelguide.gr> <534AEF68.5090002@travelguide.gr> <534AF876.3050606@travelguide.gr> <889FDCED-AA32-4A65-B152-EA192DD82A07@gmail.com> <534AFB49.1040700@travelguide.gr> <611AED5F-D2AD-41D4-BD43-E5F9BEE2B664@gmail.com> <534C2A58.8000604@travelguide.gr> Date: Mon, 14 Apr 2014 12:57:42 -0700 Message-ID: From: Dave Taht To: "cerowrt-devel@lists.bufferbloat.net" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Cerowrt-devel] Fwd: Making sqm-scripts compatible with other packages (e.g. mwan3 multiwan) X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2014 19:57:45 -0000 some feedback on sqm. It's not clear to me how to mask out the stuff in the tc filter.... ---------- Forwarded message ---------- From: Kostas Papadopoulos Date: Mon, Apr 14, 2014 at 11:35 AM Subject: Making sqm-scripts compatible with other packages (e.g. mwan3 mult= iwan) To: dave.taht@gmail.com Hi David, I was looking at the sqm-scripts you recently posted at http://patchwork.openwrt.org/patch/5078/ https://github.com/dtaht/ceropackages-3.10/tree/master/net/sqm-scripts and noticed that the way sqm-scripts using the iptables' mark feature makes it incompatible with other packages which also use mark, such as the mwan3 multiwan script. Please consider updating sqm-scripts to use a /0xff mask, like qos-scripts does (it'd conflict with qos-scripts, but it's of little concern since since qos-scripts and sqm-scripts shouldn't be used together anyway). Best regards, KP PS: iptables mark is a 32 bits field which you can manipulate. With a mask (much like an ip subnetmask) you can tell which bits to write. You'd need to replace "-j MARK --set-mark 0x1" with "-j MARK --set-mark 0x1/0xff" which will only write over the first eight bits. In this last case it would be compatible, as e.g. mwan3 uses bits 9 - 16 grep mark net/sqm-scripts/files/usr/lib/sqm/* simple.qos:# this cleanly shows a means of going from diffserv marking simple.qos:ipt -t mangle -A QOS_MARK_${IFACE} -j MARK --set-mark 0x2 simple.qos:ipt -t mangle -A QOS_MARK_${IFACE} -m dscp --dscp-class CS1 -j MARK --set-mark 0x3 simple.qos:ipt -t mangle -A QOS_MARK_${IFACE} -m dscp --dscp-class CS6 -j MARK --set-mark 0x1 simple.qos:ipt -t mangle -A QOS_MARK_${IFACE} -m dscp --dscp-class EF -j MARK --set-mark 0x1 simple.qos:ipt -t mangle -A QOS_MARK_${IFACE} -m dscp --dscp-class AF42 -j MARK --set-mark 0x1 simple.qos:ipt -t mangle -A QOS_MARK_${IFACE} -m tos --tos Minimize-Delay -j MARK --set-mark 0x1 simple.qos:ipt -t mangle -A POSTROUTING -o $DEV -m mark --mark 0x00 -g QOS_MARK_${IFACE} simple.qos:ipt -t mangle -A POSTROUTING -o $IFACE -m mark --mark 0x00 -g QOS_MARK_${IFACE} simple.qos:# ipt -t mangle -A PREROUTING -i s+ -p tcp -m tcp --tcp-flags SYN,RST,ACK SYN -j MARK --set-mark 0x01 simple.qos:ipt -t mangle -A PREROUTING -i vtun+ -p tcp -j MARK --set-mark 0x2 # tcp tunnels need ordering simple.qos:# ipv6 support. Note that the handle indicates the fw mark bucket that is looked for stop.sh: ipt -t mangle -D POSTROUTING -o $DEV -m mark --mark 0x00 -g QOS_MARK_${IFACE} stop.sh: ipt -t mangle -D POSTROUTING -o $IFACE -m mark --mark 0x00 -g QOS_MARK_${IFACE} stop.sh: ipt -t mangle -D PREROUTING -i vtun+ -p tcp -j MARK --set-mark 0x2 --=20 Dave T=C3=A4ht NSFW: https://w2.eff.org/Censorship/Internet_censorship_bills/russell_0296_= indecent.article