From: Dave Taht <dave.taht@gmail.com>
To: "cerowrt-devel@lists.bufferbloat.net"
<cerowrt-devel@lists.bufferbloat.net>,
cerowrt@lists.bufferbloat.net, Felix Fietkau <nbd@nbd.name>
Subject: [Cerowrt-devel] [Bug #442] < vs <= in two comparisons
Date: Fri, 18 Apr 2014 20:26:12 -0700 [thread overview]
Message-ID: <CAA93jw5+k3WajwqWeSfTcbUrY=hdyHP3t=39zT_EUNjqXVm0LA@mail.gmail.com> (raw)
Could part of it be as simple as not checking for '<=' but only < in
txq_max_pending below?
in ath_tx_start:
ath_txq_lock(sc, txq);
if (txq == sc->tx.txq_map[q] &&
++txq->pending_frames > sc->tx.txq_max_pending[q] &&
!txq->stopped) {
ieee80211_stop_queue(sc->hw, q);
txq->stopped = true;
}
in ath_txq_skb_done:
if (txq->stopped &&
txq->pending_frames < sc->tx.txq_max_pending[q]) {
ieee80211_wake_queue(sc->hw, q);
txq->stopped = false;
}
--
Dave Täht
next reply other threads:[~2014-04-19 3:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 3:26 Dave Taht [this message]
2014-04-19 11:22 ` Felix Fietkau
2014-04-19 18:00 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA93jw5+k3WajwqWeSfTcbUrY=hdyHP3t=39zT_EUNjqXVm0LA@mail.gmail.com' \
--to=dave.taht@gmail.com \
--cc=cerowrt-devel@lists.bufferbloat.net \
--cc=cerowrt@lists.bufferbloat.net \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox