From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-x22c.google.com (mail-we0-x22c.google.com [IPv6:2a00:1450:400c:c03::22c]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id B3D6421F249; Fri, 18 Apr 2014 20:26:14 -0700 (PDT) Received: by mail-we0-f172.google.com with SMTP id t61so2124806wes.31 for ; Fri, 18 Apr 2014 20:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=ikulE6isTfzlaIQFst/WObW1ilprVOPsHZ6y6vFJ54M=; b=voJihLRwuTMdVdU4+mo2gguay7Rx6QGwcblgWFQnz23uQQSHCXe3JIN4Zt0tMTxuvS T1SwMUThD7PznqXklowKrhL2tzCanDEw7KB3OmHhgjTBIt1jBUAxM7wnzfZuLvrYhTOl 1i+x7aMFg+3/gByUmpYDbikHycZ8PLbJf/GbWzbu9+VDL/KX4mwxjqnjtzAg5ls6EZwp HN3dqCfQu8J1tLFHHlukKBJIBV4ZVPiewnR9iv+np9FvKSq/Xyx5JlQzRQpTnYJPLTaJ 5QG07R9aGWJ35NdtkyQgsDYf7aS1rq0Id+jdDPW/qZQfD2j3FbApKk3Qlyp0thDBvIi6 BrNw== MIME-Version: 1.0 X-Received: by 10.180.85.10 with SMTP id d10mr5001183wiz.0.1397877972560; Fri, 18 Apr 2014 20:26:12 -0700 (PDT) Received: by 10.216.177.10 with HTTP; Fri, 18 Apr 2014 20:26:12 -0700 (PDT) Date: Fri, 18 Apr 2014 20:26:12 -0700 Message-ID: From: Dave Taht To: "cerowrt-devel@lists.bufferbloat.net" , cerowrt@lists.bufferbloat.net, Felix Fietkau Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Cerowrt-devel] [Bug #442] < vs <= in two comparisons X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Apr 2014 03:26:15 -0000 Could part of it be as simple as not checking for '<=3D' but only < in txq_max_pending below? in ath_tx_start: ath_txq_lock(sc, txq); if (txq =3D=3D sc->tx.txq_map[q] && ++txq->pending_frames > sc->tx.txq_max_pending[q] && !txq->stopped) { ieee80211_stop_queue(sc->hw, q); txq->stopped =3D true; } in ath_txq_skb_done: if (txq->stopped && txq->pending_frames < sc->tx.txq_max_pending[q]) { ieee80211_wake_queue(sc->hw, q); txq->stopped =3D false; } --=20 Dave T=C3=A4ht