Development issues regarding the cerowrt test router project
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: cerowrt-devel@lists.bufferbloat.net
Subject: [Cerowrt-devel] trivial 6in4 fix(?)
Date: Fri, 7 Jun 2013 10:13:40 -0700	[thread overview]
Message-ID: <CAA93jw57zLSy8t-g5yPqLYB0WmgtxG0Nnt9rQkKokLktNHrFBg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]

The 3.8.13-6 dev non-release has a trivial patch in it that I hoped would
improve 6in4 and 6to4 tunneling performance. I'm not in a position to test
at the moment.

I am curious: Is there a current user of cero using simplest.qos, tunneling
ipv6 via hurricane or 6to4, that can hammer it with multiple ipv6 streams
(as in the rrul test)? (If you have rrul and ipv6, you can force it to do
pure ipv6 testing with the -6 option.)

During that test, the output, on 3.8.13-5 and earlier, of

tc -s class show dev ge00

I *think*, will show only a few fq_codel classes in use, rather than one
per stream. (you may need to run the command a few times to identify all
the streams in use)

It looked to me that the following patch would de-encapsulate the 6in4
stuff for purposes of the fq_codel flow hash calculation, and fix it... (I
put this patch into -6 but haven't tested)

---
 net/core/flow_dissector.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 00ee068..25ebce7 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -138,6 +138,8 @@ ipv6:
                }
                break;
        }
+       case IPPROTO_IPV6:
+               proto = __constant_htons(ETH_P_IPV6);
        case IPPROTO_IPIP:
                goto again;
        default:
--
1.8.1.2

-- 
Dave Täht

Fixing bufferbloat with cerowrt:
http://www.teklibre.com/cerowrt/subscribe.html

[-- Attachment #2: Type: text/html, Size: 1660 bytes --]

             reply	other threads:[~2013-06-07 17:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 17:13 Dave Taht [this message]
2013-06-16 18:56 ` Toke Høiland-Jørgensen
2013-06-16 19:13   ` Dave Taht
2013-06-16 19:19     ` Dave Taht
2013-06-16 19:21     ` Toke Høiland-Jørgensen
2013-06-16 19:27       ` Dave Taht
2013-06-16 19:36         ` Toke Høiland-Jørgensen
2013-06-16 19:38           ` Toke Høiland-Jørgensen
2013-06-16 20:32           ` Sebastian Moeller
2013-06-16 20:55             ` Toke Høiland-Jørgensen
2013-06-16 20:57               ` Dave Taht
2013-06-16 20:58                 ` Toke Høiland-Jørgensen
2013-06-17  7:35                 ` Sebastian Moeller
2013-06-17  7:30               ` Sebastian Moeller
2013-06-17  9:44                 ` Toke Høiland-Jørgensen
2013-06-17 10:40                   ` Sebastian Moeller
2013-06-17 10:50                     ` Toke Høiland-Jørgensen
2013-06-17 12:27                       ` Sebastian Moeller
2013-07-09 15:06                       ` Sebastian Moeller
2013-06-16 19:21   ` Dave Taht
2013-06-16 19:30     ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw57zLSy8t-g5yPqLYB0WmgtxG0Nnt9rQkKokLktNHrFBg@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=cerowrt-devel@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox