From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 99A563B29E for ; Tue, 11 Dec 2018 15:36:11 -0500 (EST) Received: by mail-qt1-x844.google.com with SMTP id i7so18005416qtj.10 for ; Tue, 11 Dec 2018 12:36:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=75r1tn0VwbUavKdzvc4CiJo5IsACMrAju78py/QTN+A=; b=oplfG1ikXAN9V7zmLXPgFbryCmjXz5THtgRd62Qh2Az2EVsC7Zj6ulE1Xg0PsQu9sf rr4R7M2Joj1jGFI2STpLLRxg/BfdoLCv2nJoUDMFe9GymiVHrX5h5k9FlXUynBNfmYSc qq1uCj4wdvczrWzEqNMNpdMGCp6FaMvgX02TrfDujFlHNG1PeX/7ozX0M+TdLWnMqvpe Fq99T/oJr4AxkCQtHFTsT9CY4leDyAdlwX448cDF7UNkBR7KVbMsY7nJIwc2yOtcK4mz vTnZytozL3mxY0gE2s1JhO2YDelf7kE3hzKS5S3oFMOv4Uwoqo/hfYe0TiO9fjaGBigT se0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=75r1tn0VwbUavKdzvc4CiJo5IsACMrAju78py/QTN+A=; b=sB/Pdw2m0uA5gMvImI8Q+2XOGlV4roBj47SJK9qgZlvnAvPX5z13DvlAH8b8BmsTZi BRlnqcYE7iLlaGT9rE0r33kiOWKJDNTD0vXeFvPYGNzHpd9T5W1ajy5gI+04qNIBiywX kyiq7PoNUcGS9bvFepj4HRnLztBFFKd9Evqgk2gkRKkrQ8J9mmI/bHU37YLe0LOtg6jD YLTrw7OhNVdKGtPsexxtSvbvWcNQGVrApXJGKJNQjeQqnb6a1fDkN4XpwGhTeLoJCsCH 2zrOwiNWz2Wx2hy0wWWLOqYIS0bcZ3RGtglc63nkRWfdVwVS+o7gF2PndxxcuaRjIDCU 9Rrg== X-Gm-Message-State: AA+aEWbLB2F4E6B32OkdShE0WyC5AJGFuwOea0gFt6bES+xZTEvtOBFI 1XoR++Jkn/k3Nou6KmRDWeSxY15qHiYO92Ygpzo= X-Google-Smtp-Source: AFSGD/Upj5EaBiNBgR7B6cJWGHiXtIXc3lqiLTP6kA2E0ryd4BCR/TGo71WG+NBTpj4sBs60YfqmMTB7WJHxC34LYL8= X-Received: by 2002:ac8:5314:: with SMTP id t20mr17141828qtn.328.1544560571084; Tue, 11 Dec 2018 12:36:11 -0800 (PST) MIME-Version: 1.0 References: <87bm5zgkkg.fsf@toke.dk> <1A5DC4D6-EAE7-4FE5-A553-A8989621907E@gmail.com> <87o99rizii.fsf@toke.dk> In-Reply-To: <87o99rizii.fsf@toke.dk> From: Dave Taht Date: Tue, 11 Dec 2018 12:35:58 -0800 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Jonathan Morton , Aaron Wood , cerowrt-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cerowrt-devel] fq_pie for linux X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 20:36:11 -0000 On Tue, Dec 11, 2018 at 12:23 PM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Jonathan Morton writes: > > >> On 11 Dec, 2018, at 8:32 pm, Aaron Wood wrote: > >> > >> With all the variants of fq+AQM, maybe decoupling the FQ part and the > >> AQM part would be worthwhile, instead of reimplementing it for each > >> variant... > >> > >> That's a great idea, Toke. There are a lot of places where I think it= could work well, especially if it took a pluggable hash function for the h= ashing (at which point it's very general-purpose, and works on all sorts of= different kinds of packets and workloads). That would let it be used for = userspace VPN links (as an example), or within QUIC (or similar), where the= kernel can't see the embedded flows that are hidden by the TLS encryption. > >> > >> And having it pluggable in the kernel would also allow IPSec to work > >> without bloat (last I checked it was horribly bufferbloated, but that > >> was ~5 years ago). > > > > I wonder if it's worth extracting the triple-isolate and > > set-associative hash logic from Cake for this purpose? The interface > > to COBALT is clean enough to be replaced by other AQMs relatively > > easily. > > There's already a reusable FQ structure in the kernel (which is what the > WiFi stack uses), which is partially modelled on Cake's tins. I had half > a mind to try to have the two converge; Cake would shed some LOCs, and > the WiFi stack could get set-associativity... I'm totally not sold on the need for set-associativity. Recently though, I started thinking about doing dynamic minimal perfect hashing, as most ip addresses (and for that matter, mac addresses) are pretty long term stable. If we can calculate a minimal perfect hash (see cmph for example) fairly rapidly set associativity goes away... (but I don't have huge hopes for it as yet) I'm also impressed with the early analysis of cobalt's AQM implementation. I would like very much, however, for a close look at how much ack-filtering would benefit wifi. and funding for next year is on my mind. Not sure how to wedge anything into nl.net's RFP, but... And then there's the class-e stuff busy, busy, busy. Fixing the internet never ends! > > -Toke > _______________________________________________ > Cerowrt-devel mailing list > Cerowrt-devel@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cerowrt-devel --=20 Dave T=C3=A4ht CTO, TekLibre, LLC http://www.teklibre.com Tel: 1-831-205-9740