From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-x235.google.com (mail-wg0-x235.google.com [IPv6:2a00:1450:400c:c00::235]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 2FA5C21F214 for ; Fri, 13 Dec 2013 22:26:28 -0800 (PST) Received: by mail-wg0-f53.google.com with SMTP id k14so2684029wgh.8 for ; Fri, 13 Dec 2013 22:26:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=m8NsoeeciooIIufVkKKtC8rMojKdroD4k7Ol2Yesx8E=; b=eYUy2p/rNVyXoC3KZ5PXh0ZuJk/LLSyQoj+iEJPTSrmZpgJr2LfTStnVBORY/YFLvk M/TWJSLQQkbM2498dozqHrubNqee1n1iBfwkzwa4TuYk4WRE+kcu7Jm7WYem4+VpqOyG FRPd82MxzJOIlzdv2T99k6NZXHkZJ+F9D0lxMWGkSFesAvGl4R9LtSj3w4cyU1uOgeWG emNRk6l/RaL1DSqWrwb3boyNiWFmQ5eI3/KCMZwbFAqARRGPn3GVwi5MEwKsFikWHR3h 2EPNW8wRhtpMyZ1M0LYopUlZB4HEBw6H6ADiRb4zlLOZm/MdfXorUHwCn3cxVX00+O0/ g5Tw== MIME-Version: 1.0 X-Received: by 10.180.37.69 with SMTP id w5mr5548554wij.53.1387002386058; Fri, 13 Dec 2013 22:26:26 -0800 (PST) Received: by 10.217.123.69 with HTTP; Fri, 13 Dec 2013 22:26:25 -0800 (PST) Date: Fri, 13 Dec 2013 22:26:25 -0800 Message-ID: From: Dave Taht To: "cerowrt-devel@lists.bufferbloat.net" , Jesper Dangaard Brouer Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: [Cerowrt-devel] aqm gui feedback on cerowrt-3.10.24-1 for linklayer adaption X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Dec 2013 06:26:28 -0000 one of the things that makes me happy with all-up testing is that occasionally after completely blowing up my own work, I get to critique fresh work that isn't mine, in an area with which I have no expertise, with gratitude that I don't have to figure out the answer. :) So I spent some time clicking wildly all over the AQM gui webpage to see what I could break. 1) the aqm gui code doesn't work due to a bug at line 66. sc:depends("advanced", "1"). sc has to be initialized first, which happens later in the file. Extra line removed in ceropackages, committed, pushed, you will need to do a pull. Merge failure? 2) it's not clear to me we have to support both the stab and htb_private methods of fixing htb's linklayer. It was important that these be fixed for everyone else that uses htb, but is one of these is faster than the other? I seem to recall one was a calculated value in the kernel, the other some sort of table. Does this choice need to be made by the user? The two variants benchmarked? Jesper? 3) Clicking "advanced configuration" on and off toggles display of the qdisc and qdisc script, and twiddling with the linklayer value brings up all the extra DSL detail. Yea! ... and I think I was wrong in mentally visualizing the thing If these were made tabs [Basic, Queueing Discipline, Linklayer, Priorities], there would be more room for explanatory text in particular and better alignment with the "look and feel" of the rest of the gui. Note that "priorities" is a placeholder for somehow bringing out something remotely similar to what openwrt's qos system already does and what AQM (ceroshaper? some other name is needed) does implicitly with optimizing for dns and ntp. ECN enablement should be brought out in "Queueing discipline" via the ALLECN variable. It seems likely ALLECN needs to have 4 states rather than 3, which needs to also be fixed in the scripts. While I'm at it, perhaps having tabs for each physical interface is not a horrible idea, but I shudder to think of people rate-limiting their wifi in the hope that that would help. ? 5) Adding a second interface shows @ge01 as an option, which isn't a real interface, and se00 as an option and not the gw* or sw* interfaces. Adding se00 with the default option gives me an error One or more required fields have no value! One or more required fields have no value! One or more required fields have no value! One or more required fields have no value! (and I'm pretty sure the aqm-scripts break even if this is correctly written to the config file) 6) feel free to add your copyright to the code. :) I return now to figuring out why bringing up the wifi is so hosed. I will probably be reverting the kernel, netifd, and other things, way, way, way back to when they used to work. --=20 Dave T=E4ht Fixing bufferbloat with cerowrt: http://www.teklibre.com/cerowrt/subscribe.= html