Development issues regarding the cerowrt test router project
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: cerowrt-devel <cerowrt-devel@lists.bufferbloat.net>
Subject: [Cerowrt-devel] Fwd: [PATCH net-next] ifb: Depend on netfilter alternatively to tc
Date: Tue, 26 Oct 2021 09:24:15 -0700	[thread overview]
Message-ID: <CAA93jw6mcNHxzpVMvsF1QxMcVci6Ckr0DS0zAzofVC7micaXwQ@mail.gmail.com> (raw)
In-Reply-To: <c8b883e60f7b143ed438fd6b032a054572acee47.1635225091.git.lukas@wunner.de>

any benefits to getting away from mirred?

---------- Forwarded message ---------
From: Lukas Wunner <lukas@wunner.de>
Date: Tue, Oct 26, 2021 at 12:11 AM
Subject: [PATCH net-next] ifb: Depend on netfilter alternatively to tc
To: David S. Miller <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, Jozsef Kadlecsik
<kadlec@netfilter.org>, Florian Westphal <fw@strlen.de>,
<netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>,
<netdev@vger.kernel.org>, Jamal Hadi Salim <jhs@mojatatu.com>, Cong
Wang <xiyou.wangcong@gmail.com>, Jiri Pirko <jiri@resnulli.us>, Daniel
Borkmann <daniel@iogearbox.net>, Willem de Bruijn <willemb@google.com>


IFB originally depended on NET_CLS_ACT for traffic redirection.
But since v4.5, that may be achieved with NFT_FWD_NETDEV as well.

Fixes: 39e6dea28adc ("netfilter: nf_tables: add forward expression to
the netdev family")
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Cc: <stable@vger.kernel.org> # v4.5+: bcfabee1afd9: netfilter:
nft_fwd_netdev: allow to redirect to ifb via ingress
Cc: <stable@vger.kernel.org> # v4.5+
---
 drivers/net/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f37b1c56f7c4..dd335ae1122b 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -150,7 +150,7 @@ config NET_FC

 config IFB
        tristate "Intermediate Functional Block support"
-       depends on NET_CLS_ACT
+       depends on NET_ACT_MIRRED || NFT_FWD_NETDEV
        select NET_REDIRECT
        help
          This is an intermediate driver that allows sharing of
--
2.31.1



-- 
Fixing Starlink's Latencies: https://www.youtube.com/watch?v=c9gLo6Xrwgw

Dave Täht CEO, TekLibre, LLC

           reply	other threads:[~2021-10-26 16:24 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <c8b883e60f7b143ed438fd6b032a054572acee47.1635225091.git.lukas@wunner.de>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw6mcNHxzpVMvsF1QxMcVci6Ckr0DS0zAzofVC7micaXwQ@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=cerowrt-devel@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox