From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dave.taht@gmail.com>
Received: from mail-wi0-x22a.google.com (mail-wi0-x22a.google.com
	[IPv6:2a00:1450:400c:c05::22a])
	(using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority G2" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 5191221F231;
	Sat, 19 Apr 2014 11:00:41 -0700 (PDT)
Received: by mail-wi0-f170.google.com with SMTP id bs8so558748wib.5
	for <multiple recipients>; Sat, 19 Apr 2014 11:00:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	bh=+elXxbe8l4ZfacLj3DTfFSeNkHRii11CujdPwKb3ze0=;
	b=Fp9idrRjdOb9l7BRREOTrRG5SgVs5zugwQgttKtmMJyqItlG0nc1GM8rbRXw4f5M3J
	XTdGrq3sjkB7Jr9Mk9Ofa8evtNG9JJZtrqm7gIgYt8YlB2zAaYCIJvDMmCpL/dF+HXiD
	ppFAvYD9Wvau+jZ2eWeaswhgUO2oUuko2MiDbMpUeEhU2bybuysh/aabkA+gjG6ENvpw
	oPqfzvFgHDD+r6EwXmNSRoGC7T2Q8Ea0fFDQ+hFGXOaJDqFvq0GxBtA3gWlQ7N+M2g2E
	sE2gx57q8e766f8MZB4FaNGYAJvaYrtJamkHqXaapHkrgCCX9UyGVKvv4E3j/pARdiDv
	ECAg==
MIME-Version: 1.0
X-Received: by 10.180.76.166 with SMTP id l6mr7422843wiw.17.1397930439205;
	Sat, 19 Apr 2014 11:00:39 -0700 (PDT)
Received: by 10.216.177.10 with HTTP; Sat, 19 Apr 2014 11:00:39 -0700 (PDT)
In-Reply-To: <53525C84.8030809@openwrt.org>
References: <CAA93jw5+k3WajwqWeSfTcbUrY=hdyHP3t=39zT_EUNjqXVm0LA@mail.gmail.com>
	<53525C84.8030809@openwrt.org>
Date: Sat, 19 Apr 2014 11:00:39 -0700
Message-ID: <CAA93jw6woReS_JwjLhDpn9Dbaty2PxXF6b5uqzUZxayFeQd6Mw@mail.gmail.com>
From: Dave Taht <dave.taht@gmail.com>
To: Felix Fietkau <nbd@openwrt.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: cerowrt@lists.bufferbloat.net, "cerowrt-devel@lists.bufferbloat.net"
	<cerowrt-devel@lists.bufferbloat.net>
Subject: Re: [Cerowrt-devel] [Bug #442] < vs <= in two comparisons
X-BeenThere: cerowrt-devel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Development issues regarding the cerowrt test router project
	<cerowrt-devel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cerowrt-devel>,
	<mailto:cerowrt-devel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cerowrt-devel>
List-Post: <mailto:cerowrt-devel@lists.bufferbloat.net>
List-Help: <mailto:cerowrt-devel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cerowrt-devel>,
	<mailto:cerowrt-devel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sat, 19 Apr 2014 18:00:41 -0000

On Sat, Apr 19, 2014 at 4:22 AM, Felix Fietkau <nbd@openwrt.org> wrote:
> On 2014-04-19 05:26, Dave Taht wrote:
>> Could part of it be as simple as not checking for '<=3D'  but only < in
>> txq_max_pending below?
> I don't see how that would make any meaningful difference in practice.

Didn't think it would, still thought <=3D was more correct.

> By the way, did you test my patch?

It is in the as yet untested 3.10.36-6 build, along with resetting qlen
down to 12 again to try to trigger the bug sooner.

http://snapon.lab.bufferbloat.net/~cero2/cerowrt/wndr/3.10.36-6/


>
>> in ath_tx_start:
>>
>>         ath_txq_lock(sc, txq);
>>         if (txq =3D=3D sc->tx.txq_map[q] &&
>>             ++txq->pending_frames > sc->tx.txq_max_pending[q] &&
>>             !txq->stopped) {
>>                 ieee80211_stop_queue(sc->hw, q);
>>                 txq->stopped =3D true;
>>         }
>>
>> in ath_txq_skb_done:
>>
>>         if (txq->stopped &&
>>             txq->pending_frames < sc->tx.txq_max_pending[q]) {
>>                 ieee80211_wake_queue(sc->hw, q);
>>                 txq->stopped =3D false;
>>         }
>>
>>
>



--=20
Dave T=C3=A4ht

NSFW: https://w2.eff.org/Censorship/Internet_censorship_bills/russell_0296_=
indecent.article