From: Dave Taht <dave.taht@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: "cerowrt-devel@lists.bufferbloat.net"
<cerowrt-devel@lists.bufferbloat.net>
Subject: Re: [Cerowrt-devel] ?Bug in cerowr-3.10t cake sqm-scripts
Date: Sat, 2 May 2015 02:38:18 -0700 [thread overview]
Message-ID: <CAA93jw734BaUikapM_6_wPg2dhjWtw8yub2yMN2NVfs3GefL6g@mail.gmail.com> (raw)
In-Reply-To: <554498B0.8010400@darbyshire-bryant.me.uk>
fix committed and pushed. Thx for the spot!
On Sat, May 2, 2015 at 2:28 AM, Kevin Darbyshire-Bryant
<kevin@darbyshire-bryant.me.uk> wrote:
> See patch for your perusal but it looks like ingress qdisc is incorrectly applied to the source interface
> rather than the ifb interface. Running /etc/init.d/sqm stop/start manually on openwrt threw an error.
>
> With the patch the right interfaces have the right qdiscs and bandwidths.
>
>
> diff --git a/net/sqm-scripts/files/usr/lib/sqm/simple.qos b/net/sqm-scripts/files/usr/lib/sqm/simple.qos
> index faeb4ec..3c5f2b5 100755
> --- a/net/sqm-scripts/files/usr/lib/sqm/simple.qos
> +++ b/net/sqm-scripts/files/usr/lib/sqm/simple.qos
> @@ -157,7 +157,7 @@ then
> sqm_logger "Do not perform DSCP based filtering on ingress. (1-tier classification)"
> # Revert to no dscp based filtering
> case $QDISC in
> - cake*) $TC qdisc add dev $IFACE root $QDISC bandwidth ${DOWNLINK}kbit besteffort ;;
> + cake*) $TC qdisc add dev $DEV root $QDISC bandwidth ${DOWNLINK}kbit besteffort ;;
> *)
> $TC qdisc add dev $DEV root handle 1: `get_stab_string` htb default 10
> $TC class add dev $DEV parent 1: classid 1:1 htb $LQ rate ${DOWNLINK}kbit ceil ${DOWNLINK}kbit `get_htb_adsll_string`
> @@ -169,7 +169,7 @@ esac
> else
> sqm_logger "Perform DSCP based filtering on ingress. (3-tier classification)"
> case $QDISC in
> - cake*) $TC qdisc add dev $IFACE root $QDISC bandwidth ${DOWNLINK}kbit $CAKE_OPTS;;
> + cake*) $TC qdisc add dev $DEV root $QDISC bandwidth ${DOWNLINK}kbit $CAKE_OPTS;;
> *)
> $TC qdisc add dev $DEV root handle 1: `get_stab_string` htb default 12
> $TC class add dev $DEV parent 1: classid 1:1 htb $LQ rate ${CEIL}kbit ceil ${CEIL}kbit `get_htb_adsll_string`
>
>
>
> --
> Thanks,
>
> Kevin@Darbyshire-Bryant.me.uk
>
>
>
> _______________________________________________
> Cerowrt-devel mailing list
> Cerowrt-devel@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cerowrt-devel
>
--
Dave Täht
Open Networking needs **Open Source Hardware**
https://plus.google.com/u/0/+EricRaymond/posts/JqxCe2pFr67
prev parent reply other threads:[~2015-05-02 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 9:28 Kevin Darbyshire-Bryant
2015-05-02 9:38 ` Dave Taht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA93jw734BaUikapM_6_wPg2dhjWtw8yub2yMN2NVfs3GefL6g@mail.gmail.com \
--to=dave.taht@gmail.com \
--cc=cerowrt-devel@lists.bufferbloat.net \
--cc=kevin@darbyshire-bryant.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox