From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-x232.google.com (mail-ob0-x232.google.com [IPv6:2607:f8b0:4003:c01::232]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 8ECD421F30E for ; Sat, 2 May 2015 02:38:19 -0700 (PDT) Received: by obblk2 with SMTP id lk2so40044660obb.0 for ; Sat, 02 May 2015 02:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=N0275h8cfjEAwl/GVPPT82EVXapnSIX/swnQvXfmv8I=; b=PX+AIM453D+zI4IOrBVenrwYT6YXxPqOH83Cukm27mCEfIzB4WtQLl5DYAf+v2MM7t 7Fe+ZHbkYW4F0nF95Ch83UN3F5ZmfPZA3ircKSQNHK5jkEhGLFeh8UTCe4DBg2Rn/9mv D7/6PE3o6m7StQTmc+2H3FOFtm+PgO3KAgyTyYq/p4d/TLZ4HMYU4MSTwGKHxEna856X LCpA7JpGH4FlNwQWyFne/zNpAI+Cou4Rg6SIkxE1daGf2/UIr4dFGS+8ooQ7pAAtT32o IMnrM9CNc6X7Ls0yssxixV5eAMW/VMwqcHOlVND6eQlCIptwWRTN9SZNbn+yIKpTx62O tKJw== MIME-Version: 1.0 X-Received: by 10.202.227.130 with SMTP id a124mr10537738oih.59.1430559498325; Sat, 02 May 2015 02:38:18 -0700 (PDT) Received: by 10.202.71.139 with HTTP; Sat, 2 May 2015 02:38:18 -0700 (PDT) In-Reply-To: <554498B0.8010400@darbyshire-bryant.me.uk> References: <554498B0.8010400@darbyshire-bryant.me.uk> Date: Sat, 2 May 2015 02:38:18 -0700 Message-ID: From: Dave Taht To: Kevin Darbyshire-Bryant Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "cerowrt-devel@lists.bufferbloat.net" Subject: Re: [Cerowrt-devel] ?Bug in cerowr-3.10t cake sqm-scripts X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 May 2015 09:38:48 -0000 fix committed and pushed. Thx for the spot! On Sat, May 2, 2015 at 2:28 AM, Kevin Darbyshire-Bryant wrote: > See patch for your perusal but it looks like ingress qdisc is incorrectly= applied to the source interface > rather than the ifb interface. Running /etc/init.d/sqm stop/start manual= ly on openwrt threw an error. > > With the patch the right interfaces have the right qdiscs and bandwidths. > > > diff --git a/net/sqm-scripts/files/usr/lib/sqm/simple.qos b/net/sqm-scrip= ts/files/usr/lib/sqm/simple.qos > index faeb4ec..3c5f2b5 100755 > --- a/net/sqm-scripts/files/usr/lib/sqm/simple.qos > +++ b/net/sqm-scripts/files/usr/lib/sqm/simple.qos > @@ -157,7 +157,7 @@ then > sqm_logger "Do not perform DSCP based filtering on ingress. (1-tier clas= sification)" > # Revert to no dscp based filtering > case $QDISC in > - cake*) $TC qdisc add dev $IFACE root $QDISC bandwidth ${DOWNLINK}kbi= t besteffort ;; > + cake*) $TC qdisc add dev $DEV root $QDISC bandwidth ${DOWNLINK}kbit = besteffort ;; > *) > $TC qdisc add dev $DEV root handle 1: `get_stab_string` htb default 10 > $TC class add dev $DEV parent 1: classid 1:1 htb $LQ rate ${DOWNLINK}kbi= t ceil ${DOWNLINK}kbit `get_htb_adsll_string` > @@ -169,7 +169,7 @@ esac > else > sqm_logger "Perform DSCP based filtering on ingress. (3-tier classificat= ion)" > case $QDISC in > - cake*) $TC qdisc add dev $IFACE root $QDISC bandwidth ${DOWNLINK}kbi= t $CAKE_OPTS;; > + cake*) $TC qdisc add dev $DEV root $QDISC bandwidth ${DOWNLINK}kbit = $CAKE_OPTS;; > *) > $TC qdisc add dev $DEV root handle 1: `get_stab_string` htb default 12 > $TC class add dev $DEV parent 1: classid 1:1 htb $LQ rate ${CEIL}kbit ce= il ${CEIL}kbit `get_htb_adsll_string` > > > > -- > Thanks, > > Kevin@Darbyshire-Bryant.me.uk > > > > _______________________________________________ > Cerowrt-devel mailing list > Cerowrt-devel@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cerowrt-devel > --=20 Dave T=C3=A4ht Open Networking needs **Open Source Hardware** https://plus.google.com/u/0/+EricRaymond/posts/JqxCe2pFr67