Re: [Cerowrt-devel] was filled with hope for killing the last traps, now have brick

[Robert Bradley <robert.bradley1@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3373 bytes --]

You're right; it should indeed be "net_hdr_word(&addr[fn_bit >> 5]);".
That's my fault for not checking the patches thoroughly enough.  I'm more
than a bit surprised the compiler accepted that code as-is...


On 21 January 2013 13:50, Ketan Kulkarni <ketkulka@gmail.com> wrote:

> Looking at the patch -
>
> -              addr[fn_bit >> 5];
> +              net_hdr_word(addr[fn_bit >> 5]);
>
> Should the above line be - (& missing in the above line??)
>
> +              net_hdr_word(&addr[fn_bit >> 5]);
>
> -Ketan
>
> On Mon, Jan 21, 2013 at 6:51 PM, Ketan Kulkarni <ketkulka@gmail.com>
> wrote:
> > Well with this 3.7.3-1, I didnt see any crashes. I didnt change any
> > default config.
> > The router boots up well (in fact writing this mail through the same)
> > I also note I use IPv4 network only.
> >
> > I collected dmesg after booting up and kept here (in case required) -
> > http://pastebin.com/p1aM1aV8
> >
> > -Ketan
> >
> >
> > On Mon, Jan 21, 2013 at 2:31 PM, Dave Taht <dave.taht@gmail.com> wrote:
> >> A build without that patch is now up here:
> >>
> >> http://snapon.lab.bufferbloat.net/~cero2/cerowrt/wndr/3.7.3-1/
> >>
> >> so 1/3 of the potential causes is not there....
> >>
> >> On Mon, Jan 21, 2013 at 3:51 AM, Ketan Kulkarni <ketkulka@gmail.com>
> wrote:
> >>>
> >>> Hi Dave,
> >>> Probably I can take a look later tonight by having serial cable - I
> >>> have that one handy.
> >>> What is the build and how to re-create the scenario?
> >>>
> >>
> >> Well, I hate to commit sources when stuff is obviously borked. If you
> >> want to try flashing with that you can figure out if it was us or the
> merge
> >> that went bad....
> >>
> >>
> >>
> >>
> >>>
> >>> Thanks,
> >>> Ketan
> >>>
> >>>
> >>> On Mon, Jan 21, 2013 at 12:54 AM, Dave Taht <dave.taht@gmail.com>
> wrote:
> >>> > Mine and Robert Bradley's latest attempt at killing the last ipv6
> >>> > instruction traps
> >>> > with a rollup patch from bugs 419 and 421...
> >>> >
> >>> > brick the router. It boots, the main green light goes on, then it
> dies.
> >>> > Naturally
> >>> > I left the serial cable at the office...
> >>> >
> >>> > Of course in the middle of this patch set revision I also updated to
> >>> > 3.7.3
> >>> > and openwrt head,
> >>> > so have a few more variables than usual than just us to cope with.
> >>> >
> >>> > I would not mind eyeballs on this to see if there is an obvious flaw,
> >>> > otherwise I will progressively bisect from what was known to work
> >>> > forward as fast as I can. (besides, the hope is to  submit this
> >>> > upstream)
> >>> >
> >>> > net_hdr_word is defined in the 902-unaligned_access_hacks patch in
> >>> > openwrt
> >>> > head...
> >>> >
> >>> > now off to find a small, sharp, pointy object...
> >>> >
> >>> > --
> >>> > Dave Täht
> >>> >
> >>> > Fixing bufferbloat with cerowrt:
> >>> > http://www.teklibre.com/cerowrt/subscribe.html
> >>> >
> >>> > _______________________________________________
> >>> > Cerowrt-devel mailing list
> >>> > Cerowrt-devel@lists.bufferbloat.net
> >>> > https://lists.bufferbloat.net/listinfo/cerowrt-devel
> >>> >
> >>
> >>
> >>
> >>
> >> --
> >> Dave Täht
> >>
> >> Fixing bufferbloat with cerowrt:
> >> http://www.teklibre.com/cerowrt/subscribe.html
>



-- 
Robert Bradley

[-- Attachment #2: Type: text/html, Size: 5338 bytes --]